Previous Thread
Next Thread
Print Thread
Rate Thread
Page 2 of 3 1 2 3
Joined: Nov 2003
Posts: 482
Enthusiast
Enthusiast
Offline
Joined: Nov 2003
Posts: 482
i'm a 2 space guy smile

Sponsored Links
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Exactly, everyone has their preferences, so when possible I try to follow best practices as outlined by the people who write php smile


- Allen wavey
- What Drives You?
Joined: Nov 2003
Posts: 482
Enthusiast
Enthusiast
Offline
Joined: Nov 2003
Posts: 482
ubbthreads is 2 space based, if you wanted it to match what it is using wink

but whatever fluffs your flannel is ok with me..

that's what powerful editors are for anyway. it's like a 2 command dealio in UltraEdit to change it from 4 to 2..

no biggie..

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
I'm so glad I have your approval wink

I know this is not based on the zend framework, but I set my text editor up with the tabs based on their recommendations:

http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html

http://framework.zend.com/manual/en/coding-standard.coding-style.html

I know I have asked several times to pay someone to code this for me... I couldn't even pay for it so I'm doing it myself. Take up your spaces fetish with the zend people and let me know how it turns out. wink Or you could contribute to the project...


- Allen wavey
- What Drives You?
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Minor version release to (hopefully) fix the html bug zarzal was seeing with subcats and sanitize the fave/rate submissions:

7.3.1a (released 7/2/2008):
- fixed xhtml issue with subcats
- added fave and rating submission sanitization

First post has latest code.


- Allen wavey
- What Drives You?
Sponsored Links
Joined: Jul 2001
Posts: 808
Coder
Coder
Joined: Jul 2001
Posts: 808
Originally Posted by AllenAyres
Odd zarzal, not sure what to tell you. When you do a
SELECT * FROM ubbt_links_categories

does cat_order match up with what you are seeing in your links control panel?
seems so. I attach a result of the query as screenshot.
It looks that the sort follows cat_id if parrent_id = 0 and not cat_order
Attachments
sortorder.jpg (95.64 KB, 7 downloads)

Last edited by Zarzal; 07/02/2008 1:00 PM.
Zarzal #317361 07/02/2008 1:35 PM
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
I think I adjusted one SORT BY in the most recent version, can you upload the links.inc.php from the current zip and let me know if it fixed your html error and sort order? danke smile


- Allen wavey
- What Drives You?
Joined: Jul 2001
Posts: 808
Coder
Coder
Joined: Jul 2001
Posts: 808
I already try the latest version, but no changes frown Can you change the sortorder on your system?
The html problem seems to be fixed. But right now I found a new layout problem: try pressing a green button near a link to edit it and see what happen ...

Last edited by Zarzal; 07/02/2008 3:00 PM.
Zarzal #317363 07/02/2008 3:33 PM
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Yes, sort_order changes in my test install here:

https://www.ubbdev.com/forums/ubbthreads.php/ubb/links/op/Links.html

I fixed the layout on the edit screen, there's probably 1-2 more of those left... every screen had to be updated. smile


- Allen wavey
- What Drives You?
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Please try the current zip Zarzal - maybe your combo of php/mysql didn't like the quotes in:

ORDER BY 'cat_order'

It should work either way, but maybe your case is special. smile


- Allen wavey
- What Drives You?
Sponsored Links
Joined: Jul 2001
Posts: 808
Coder
Coder
Joined: Jul 2001
Posts: 808
no, this brings an error:
Parse error: syntax error, unexpected '}' in /var/www/users/d/d00003/websites/dragonclan-forum.de/board/scripts/links.inc.php on line 1090

/update:

aaahhhhh, the sortorder works. I insert the following block again that you have removed:
Code
function linkRating () {
if ((!$row[totalvotes]) || (!$row[linkratingsummary])) {
$average = 0;
} else {
$average = round(($row[linkratingsummary] / $row[totalvotes])-0,5);
}
$star = "";
$stars = 0;
while ($stars<$average) {
$star .= "<img src=\"{$config['BASE_URL']}/images/links/star.gif\" alt=\"{$ubbt_lang['LINKS_STAR']}\" border=\"0\" align=\"middle\" />";
$stars++;
}
now te error is gone and the sortorder work

Last edited by Zarzal; 07/03/2008 4:02 PM.
Zarzal #317370 07/03/2008 6:15 PM
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Well.... it looks like I left an extra } in there. It will be fixed on the next release. I'm glad at least we got past that bug on the sort. I'll make sure the other queries are updated too.


- Allen wavey
- What Drives You?
Joined: Jul 2008
Posts: 2
Lurker
Lurker
Offline
Joined: Jul 2008
Posts: 2
It would be incredibly useful if we could define a Group that could moderate the links that was separate from the Administrators. Am I just overlooking this feature?

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
The moderators can moderate the links smile


- Allen wavey
- What Drives You?
Joined: Jul 2008
Posts: 2
Lurker
Lurker
Offline
Joined: Jul 2008
Posts: 2
Right, but what if I don't want all of my moderators to moderate links, but only specific ones? Or specific groups of moderators?

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
That's a little over this mod so far... I'll look to get it into the next version tho smile


- Allen wavey
- What Drives You?
Zarzal #317450 07/24/2008 6:30 AM
Joined: Dec 2007
Posts: 7
Lurker
Lurker
Offline
Joined: Dec 2007
Posts: 7
I must be dumber than a skunk, but after downloading the zip file, I can not seem to find a method of "adding" ubblinks to my ubbthreads install.


Please advise with a little more substance for us "beginner" users.

Thanks

Joined: Dec 2007
Posts: 7
Lurker
Lurker
Offline
Joined: Dec 2007
Posts: 7
Woops...I guess I'm not that dumb after all.

Figured it out smile

Joined: Dec 2007
Posts: 7
Lurker
Lurker
Offline
Joined: Dec 2007
Posts: 7
Ok..now I have no clue..

Want to add a "Links" link to the breadcrumb bar. Guess its a new methodology vs 7.1 so I can not figure out how to do so.

Can someone advise?

Thanks

Joined: Dec 2007
Posts: 7
Lurker
Lurker
Offline
Joined: Dec 2007
Posts: 7
Ok,

I figured that out as well.

So now I know how to solve all my issues with UBBThreads.

First I try to make it work for days...
I give up in frustration...
I post on UBBDEV for an answer...
Then solve it myself, only AFTER posting on UBBDEV.

Hmmm....magical web site?

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Yes, we're magical smile

Sorry for not responding earlier, work has had me busy this week smile


- Allen wavey
- What Drives You?
Joined: Oct 2001
Posts: 139
Journeyman
Journeyman
Joined: Oct 2001
Posts: 139
Allen,
I would like to try to install this, but not real clear on how to set up the tables. I'm running Threads 7.3. I gather I need to create the tables needed manually, but:

1) What tables are needed?
2) What are the fields and their properties for each table?


Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
hmmm... I need to update the original post to say that this is installed by the web now. You can access it directly by going to:

ubbthreads.php?ubb=links_install


- Allen wavey
- What Drives You?
Joined: Oct 2001
Posts: 139
Journeyman
Journeyman
Joined: Oct 2001
Posts: 139
Thank Allen. I could have sworn I tried that, but will try again.

Joined: Oct 2001
Posts: 139
Journeyman
Journeyman
Joined: Oct 2001
Posts: 139
Allen, thanks - I got it working! One question though. I can see how to "sort order" the man categories, but is there a way to also sort-order the sub-cats (other that manually from the database?)

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
That's not how subcats were built way back when - the whole cats thing needs to be re-done to make it more flexible - could be simple-ish, but I need to dig some into the code smile


- Allen wavey
- What Drives You?
Joined: Aug 2008
Posts: 4
Lurker
Lurker
Offline
Joined: Aug 2008
Posts: 4
I tried installing this last night, and yes I was confused as to how to install it at first too but then figured that out, but I have 2 questions...

Are we suppose to create our own link somewhere on the site to administer or even just go to it?

Second, The layout was all jacked up when going to the main links page using the black and gold styles. I didn't even think about testing the default syles so I'm not sure if it is having the same issue with them.

I'm using 7.3.1, freshly installed this week with no other mods other than the black and gold style.

Last edited by Murphdog; 08/22/2008 9:56 AM.
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
The layout should be ok unless there's an issue with the style. I'd need to see it to find out. There's still some old code in there and it's possible a tbopen or tbclose was used without the proper corresponding tag.

You create links to it either in your overall site navigation, or in your forum's topnav template - that would be up to you to decide smile


- Allen wavey
- What Drives You?
Joined: Mar 2007
Posts: 94
Power User
Power User
Joined: Mar 2007
Posts: 94
finally got around to installing this, this is great!

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Glad you like it - tho there's a few options I'd loved to have added I think it works well for what it does smile


- Allen wavey
- What Drives You?
Joined: Mar 2007
Posts: 94
Power User
Power User
Joined: Mar 2007
Posts: 94
a feature that would be nice; notification of links waiting to be approved,

Joined: Mar 2007
Posts: 94
Power User
Power User
Joined: Mar 2007
Posts: 94
I am noticing some odd CSS issues, like when I approve a link, or add a new category, the next page has a huge gap between my header and the links menu, I thought I was getting a blank page till I scrolled down.

Joined: Mar 2007
Posts: 94
Power User
Power User
Joined: Mar 2007
Posts: 94
am I missing something? or is there no way to edit the links once they are approved? no way to delete them? correct spelling? update the link?

I see that it can be done for pending submissions, but not for anything previously approved.

I know squat about MySQL and have no clue how to edit in there.

Joined: Mar 2007
Posts: 94
Power User
Power User
Joined: Mar 2007
Posts: 94
the CSS issues seem to be with the Koniro skin,
I just figured out what the red and green dots are next to a link!

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
hehe, it's been a while since I've looked at the code, but I remember the red and green dots - they should do what you need smile


- Allen wavey
- What Drives You?
Joined: Mar 2007
Posts: 94
Power User
Power User
Joined: Mar 2007
Posts: 94
I have noticed when someone adds an ' to something, the script adds a \ before it.

so "you're" comes out like "you\'re"

Joined: Nov 2003
Posts: 482
Enthusiast
Enthusiast
Offline
Joined: Nov 2003
Posts: 482
there is probably an addslashes without a stripslashes in the code..

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Si, been a year or more since I've looked at the code smile

I may track down the offending addslashes and bug SD where to put the stripslashes smile


- Allen wavey
- What Drives You?
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
hehe, there's 4-5 addslashes and not one stripslash shocked


- Allen wavey
- What Drives You?
Joined: Nov 2003
Posts: 482
Enthusiast
Enthusiast
Offline
Joined: Nov 2003
Posts: 482
i can track it down for you allen... if you want.. just send me the latest code...

it's up to you.. you've done a fine job so far... nice addon! wink

Page 2 of 3 1 2 3

Link Copied to Clipboard
Donate Today!
Donate via PayPal

Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.

Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
Recommended Hosts
We have personally worked with and recommend the following Web Hosts:
Stable Host
bluehost
InterServer
Visit us on Facebook
Member Spotlight
JAISP
JAISP
PA
Posts: 449
Joined: February 2008
Forum Statistics
Forums63
Topics37,573
Posts293,925
Members13,849
Most Online5,166
Sep 15th, 2019
Today's Statistics
Currently Online
Topics Created
Posts Made
Users Online
Birthdays
Top Posters
AllenAyres 21,079
JoshPet 10,369
LK 7,394
Lord Dexter 6,708
Gizmo 5,833
Greg Hard 4,625
Top Posters(30 Days)
Top Likes Received
isaac 82
Gizmo 20
Brett 7
WebGuy 2
Morgan 2
Top Likes Received (30 Days)
None yet
The UBB.Developers Network (UBB.Dev/Threads.Dev) is ©2000-2024 VNC Web Services

 
Powered by UBB.threads™ PHP Forum Software 8.0.0
(Preview build 20221218)