Previous Thread
Next Thread
Print Thread
Rate Thread
Page 1 of 3 1 2 3
[7.3.x] ubb.links #317261
06/20/2008 10:50 PM
06/20/2008 10:50 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Name: ubb.links v7.3.1a

Description: Adds a links script to your site, integrated into your forum's styles, members and permissions

Demo: http://www.praisecafe.org/forum/ubbthreads.php/ubb/links/op/Links.html

Installation: DL and unzip the file. Upload the folders to the corresponding folders within your forum (ie: all files in the "scripts" folder should be uploaded to your forum's "scripts" folder).

If you are installing new, you're either going to have to manually create the tables using the code in admin script or wait until version 7.3.1 where the fix will be in for that.

If you are upgrading from Josh's 7.2 version, you're going to need to update a table's column's name:
Code
ALTER TABLE ubbt_links_categories
CHANGE title cat_title varchar(50)


Author: Plethora (see credits) - Mark Summerlin wrote the original (TLD) code 4-5 years ago, but not much is left of his work smile

Requirement: UBB.Threads 7.3.x - 7.5.x

Changelog:
7.3 alpha (released 6/20/2008):
- Now uses 7.3's SEO links
- Lots of template/design updates to look more like ubb.threads
- Removed some extraneous code, optimized some other
- ~95% of the wordlets are complete for public pages, more needs to be done for admin pages
- All public pages are xhtml-compliant

7.3 beta (released 6/25/2008):
- fixed web install, it's now a seperate file
- lots of html fixes in the admin area

7.3 gamma (released 6/28/2008):
- fixed cat sort order in cp
- lots of html fixes in the admin area
- code optimizations to match .threads 7.3 code

7.3 gold (released 6/29/2008):
- fixed bread crumb
- fixed stats
- more xhtml fixes
- css adjustments
- added censor check to new links

7.3.1 (released 6/30/2008):
- fixed invalid html characters
- added link submission sanitization

7.3.1a (released 7/2/2008):
- fixed xhtml issue with subcats
- added fave and rating submission sanitization

Known Bugs:
- cannot do web install to create table
- cat sort order
- need to fix stats at bottom
- bread crumb bug
- various html cleanups (ongoing)

Upcoming Features:
- search of links
- set up for unlimited subcat levels
- auto-fill options which pre-populate the fields with the meta data from the web site being submitted
- sticky links
- advanced sorting options
- 'report this link' - for broken, issues
- sprinkling of appropriate ajax
- Links CI (latest links, top 10, etc)
- CAPTCHA

NOTE: Above sections will be updated as we go and first post will always have most current released code.

Enjoy! smile

Attached Files
ubbLinks.zip (69 downloads)
Last edited by AllenAyres; 10/05/2009 3:58 PM.

- Allen wavey
- What Drives You?
Sponsored Links
Re: [7.3.x] ubb.links [Re: AllenAyres] #317262
06/21/2008 3:13 AM
06/21/2008 3:13 AM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
thanks, it works nice. I have to rename my old tables from w3t_ to ubbt_ first in the sql console (RENAME TABLE w3t_..... TO ubbt_.....) and then run the alter command. Now it work.
I will do a german language file.

Re: [7.3.x] ubb.links [Re: Zarzal] #317263
06/21/2008 9:56 AM
06/21/2008 9:56 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Thank you Zarzal smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317265
06/22/2008 2:41 AM
06/22/2008 2:41 AM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
German language file in the attachment. Download and unzip it and put it in /languages/german

Attached Files
links.zip (2 downloads)
Re: [7.3.x] ubb.links [Re: Zarzal] #317269
06/22/2008 8:37 AM
06/22/2008 8:37 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
danke, I'll put it in the download file in the first post so it will be available - let me know if/when you update it smile


- Allen wavey
- What Drives You?
Sponsored Links
Re: [7.3.x] ubb.links [Re: AllenAyres] #317270
06/22/2008 10:59 AM
06/22/2008 10:59 AM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
thanks. If I do changes I sent you a note.

Re: [7.3.x] ubb.links [Re: Zarzal] #317294
06/25/2008 9:49 PM
06/25/2008 9:49 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Original post updated: 7.3beta released - now you can do the web install if you haven't installed it before - the create tables routines were moved to a new file - to be safe delete after installation. I also fixed many xhtml issues in the admin area, a few bugs related to category titles, and added zarzal's german language file translation.

To upgrade if you've already installed just upload the files (skip the install file).


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317299
06/26/2008 8:34 AM
06/26/2008 8:34 AM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
Thanks. Submitting the sortorder in the admin section dont work (seems to have no effect) and if it returned from submit sortorder to main the layout is confused.

The nav breadcrumb seems to have a problem in the first sublevel: Index Fun

Last edited by Zarzal; 06/26/2008 8:38 AM.
Re: [7.3.x] ubb.links [Re: Zarzal] #317300
06/26/2008 9:00 AM
06/26/2008 9:00 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
2 new bugs, thank you smile

Sortorder probably has to do with changing title to cat_title, I'll look at the navigation too smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317302
06/26/2008 12:32 PM
06/26/2008 12:32 PM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
The sortorder on the main category never worked for me. In every version it was broken.

Sponsored Links
Re: [7.3.x] ubb.links [Re: Zarzal] #317303
06/26/2008 5:09 PM
06/26/2008 5:09 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Ah, ok smile I've never used that. I can see where it's needed tho. Will get it on the bugz list smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317312
06/28/2008 12:09 AM
06/28/2008 12:09 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Found the bug, will post the fix plus some others this weekend


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317313
06/28/2008 5:22 AM
06/28/2008 5:22 AM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
Hey, this sounds cool. Thank you.

Re: [7.3.x] ubb.links [Re: Zarzal] #317314
06/28/2008 6:41 AM
06/28/2008 6:41 AM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Your "submit" page should use the CSS from threads; I can't say much about you "light theme" guys, but let me tell you, white submit boxes on a dark background looks YIKES!

Also, when I go to make a submission, the category dropdown shows a blank entry at the top...

Additionally, once i submit a link, the page has a weird grey background; I'm guessing some bugglet in there that also throws off my table display.

Last edited by Gizmo; 06/28/2008 6:45 AM.

UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: Gizmo] #317315
06/28/2008 12:23 PM
06/28/2008 12:23 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
The blank entry at the top is intentional, so people will click and choose one instead of the default. smile I do need to update some css classes, and I've fixed a good number of html errors in the cp in my local version. I'll post it shortly smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317316
06/28/2008 12:30 PM
06/28/2008 12:30 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
OK, updated original post to current code - fixed the cat sort order, optimized some more code and fixed lots of xhtml errors in the cp again.

Still need to fix the breadcrumb error, css class issues and the stats at the bottom before we can get much into the 7.3.1/7.4 version smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317317
06/28/2008 6:52 PM
06/28/2008 6:52 PM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Anyone else getting charset issues? I have the little diamond questionmark on my UTF-8 install...

i'd recommend setting a language entry "Please Select" vs having it blank... else you get confused as to why theres a blank item wink...


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: Gizmo] #317318
06/29/2008 12:42 AM
06/29/2008 12:42 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Which page do you see the diamond?


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317320
06/29/2008 1:36 AM
06/29/2008 1:36 AM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
The "diamond" shows when there is a characterset conflict; you can test it here


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: Gizmo] #317321
06/29/2008 3:12 AM
06/29/2008 3:12 AM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
Looks nicer. Submitting of the sortorder works now but on my links main page it have no effect. My categorys stuck everytime in same same order. Can it be that I have an very old db and missing some fields in it? Can this be?

Re: [7.3.x] ubb.links [Re: Gizmo] #317323
06/29/2008 7:15 AM
06/29/2008 7:15 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Originally Posted by Gizmo
The "diamond" shows when there is a characterset conflict; you can test it here


I don't see any 'diamonds' on your links install. Not sure how there would be any characterset conflicts since it takes the charset from the forum settings.


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: Zarzal] #317324
06/29/2008 7:19 AM
06/29/2008 7:19 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Originally Posted by Zarzal
Looks nicer. Submitting of the sortorder works now but on my links main page it have no effect. My categorys stuck everytime in same same order. Can it be that I have an very old db and missing some fields in it? Can this be?


Thanks Zarzal. Maybe it's a caching issue, have they changed yet? I believe if you are able to set the order in the cp, then your database should be up to date.

The problem with the old way of setting the order (and the reason the changes never worked) was the original code was written back when people were using php 3 and 4 series - HTTP_POST_VARS has been deprecated for quite some time now and the command didn't mean anything for current versions of php - I used $_Post to get it running.


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317327
06/29/2008 9:20 PM
06/29/2008 9:20 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
OK, Gold release in first post thumbsup

The last of the major bugs were fixed (I think smile ):
- fixed bread crumb
- fixed stats
- more xhtml fixes
- css adjustments

I also:
- added censor check to new links


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317328
06/30/2008 1:27 AM
06/30/2008 1:27 AM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Well, I don't know what to tell you, cas they're there... Screencaps:
[Linked Image]
[Linked Image]

Additionally, tidy reports: "Page Error: This page contains invalid characters"


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: Gizmo] #317330
06/30/2008 7:36 AM
06/30/2008 7:36 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Those would only be viewable by the admin and why I couldn't see them on your site. They're symbols used by the original author. They don't throw errors at w3.validator.org, I'll update them on the next version. smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317336
06/30/2008 12:13 PM
06/30/2008 12:13 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
7.3.1 (released 6/30/2008):
- fixed invalid html characters - Thanks Gizzy!
- added link submission sanitization - Thanks Yarp!
- minor code cleanup

Because of the sanitization addition/correction, everyone is urged to upgrade.

To upgrade from within 7.3.x, just upload files. For earlier versions follow info in first post.


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317338
06/30/2008 3:38 PM
06/30/2008 3:38 PM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
Thank you, Allen.

I still have a sort problem. I attach some picturs. In picture lin1 you see my sort order in the admin section. In link2 you see the output of the main page. I can change the sortorder but it have no efect to the mainpage.

In picture link3 you can see 2 problems. It is a screenshot of inside a sub section. on the right side you can see a table problem in the layout.

Also I note (visibe in link3 too) that the statistic on the bottom count each section. In a subforum without links you count 0. Should this be that the counter is per page?

Attached Files
link1.jpg (84 downloads)
Sortorder admin section
link2.jpg (9 downloads)
Main Windows output
link3.jpg (10 downloads)
inside subsection layout problem, db count problem
Re: [7.3.x] ubb.links [Re: Zarzal] #317339
06/30/2008 8:14 PM
06/30/2008 8:14 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Not sure what to say, it works on 2 different installs for me. Are you running php5?

And you are correct on the stats. It needs to be updated.

Most likely, we'll be pulling this apart and seperating the pages into their own scripts with their own templates. Right now we're running into conflicts trying to run it all from one script.


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317340
06/30/2008 9:19 PM
06/30/2008 9:19 PM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Lol, bad characters to use wink

I like the idea of tearing it apart though wink

Last edited by Gizmo; 06/30/2008 9:20 PM.

UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: Zarzal] #317341
06/30/2008 9:31 PM
06/30/2008 9:31 PM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Hey AA, I wanted to test your installer for 7.3.1 but it's complaining that the tables don't exist... Which duah, I want to use the installer lol...


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: Zarzal] #317342
06/30/2008 9:34 PM
06/30/2008 9:34 PM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Just noticed the note about the seperate file; I think the install docs need to mention they need to access it as:
ubbthreads.php?ubb=links_install

I also found a bug... When you're viewing the main index without any categories, it throws an html error which skews the tables for ubb

Last edited by Gizmo; 06/30/2008 9:36 PM.

UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: Gizmo] #317343
06/30/2008 9:48 PM
06/30/2008 9:48 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Yeah, I haven't looked to do anything with that error - if you don't have any categories you really haven't finished installing it yet smile I guess we could add a "General" category with the create table functions, but most would change it anyways.


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: Gizmo] #317344
06/30/2008 9:51 PM
06/30/2008 9:51 PM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
I was thinking the images didn't look right, so I nuked them from my install, it doesn't look half bad now (clicky)

Also, AA, if you use tab's instead of spaces for separation in your files, you can cut out a lot of unneeded space... Check my example attached...

Attached Files
links.zip (3 downloads)
Last edited by Gizmo; 06/30/2008 9:54 PM.

UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: AllenAyres] #317345
06/30/2008 9:58 PM
06/30/2008 9:58 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Most likely we'll be changing the design of the categories to more closely match the design of ubb.threads forums - being able to have an unlimited/random number of columns is pretty much guaranteed to have html errors like zarzal is seeing for some sites. It's pretty much impossible to make it work for everyone.


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: Gizmo] #317346
06/30/2008 10:02 PM
06/30/2008 10:02 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Originally Posted by Gizmo
I was thinking the images didn't look right, so I nuked them from my install, it doesn't look half bad now (clicky)

Also, AA, if you use tab's instead of spaces for separation in your files, you can cut out a lot of unneeded space... Check my example attached...


Yeah, I used to do that, but it's generally recommended by the php/zend people to use tabs of 4 spaces - just so it's the same for everyone - some people use 2 spaces for tabs, others use tabs of differing sizes, others use 6 or 8 spaces for tabs. I can look it up on the zend site, but it's been a while and I just set it to 4 spaces and forget about it. smile Any part I've tabbed on is set to 4 spaces.

You're probably right about the images, it's one of those left-over things from the original code. They'll probably go away as we move closer to the forum-look. smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317347
06/30/2008 11:26 PM
06/30/2008 11:26 PM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
I look at the formatting merely as what's being used in terms of keystrokes vs how zend feels about things wink...

As for the images, they're a smidge larger than the text, so it was causing me some grief... I don't really see much of a use of them for what I'd use it for; so reguardless I'd edit them out.

I moved the spaces to AFTER the previous entry vs in FRONT of the entry as it makes visibly looking for items a little easier.


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: Gizmo] #317348
07/01/2008 7:58 AM
07/01/2008 7:58 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
I set my tabs to equal 4 spaces, it's no more keystrokes smile

Where do you mean moving the spaces? For subcats or ?


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317349
07/01/2008 9:07 AM
07/01/2008 9:07 AM
Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
Gizmo Offline

UBB.Dev / UBB.Wiki Owner
Time Lord
Gizmo  Offline

UBB.Dev / UBB.Wiki Owner
Time Lord

Joined: Jan 2000
Posts: 5,947
Portland, OR, USA
There is more keystrokes though...
One tab is One character.
4 spaces is 4 characters.


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, UBB.SitemapsJames Corthell
Re: [7.3.x] ubb.links [Re: AllenAyres] #317350
07/01/2008 11:21 AM
07/01/2008 11:21 AM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
Originally Posted by AllenAyres
Are you running php5?
yes: PHP Version 5.2.5-3

Re: [7.3.x] ubb.links [Re: Gizmo] #317351
07/01/2008 12:48 PM
07/01/2008 12:48 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Odd zarzal, not sure what to tell you. When you do a

SELECT * FROM ubbt_links_categories

does cat_order match up with what you are seeing in your links control panel?

Originally Posted by Gizmo
There is more keystrokes though...
One tab is One character.
4 spaces is 4 characters.


I know what you are trying to say... I used to be able to shrink photopost's filesize by half just by removing trailing spaces and converting leading spaces to tabs. The php/zend people recommend 4 spaces for each tab, so... you might bring your beef up with them and let me know if they make changes in those recommendations smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317352
07/01/2008 4:34 PM
07/01/2008 4:34 PM
Joined: Nov 2003
Posts: 491
SoCal
S
sirdude Offline
Enthusiast
sirdude  Offline
Enthusiast
S

Joined: Nov 2003
Posts: 491
SoCal
i'm a 2 space guy smile

Re: [7.3.x] ubb.links [Re: sirdude] #317353
07/01/2008 4:55 PM
07/01/2008 4:55 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Exactly, everyone has their preferences, so when possible I try to follow best practices as outlined by the people who write php smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317354
07/01/2008 6:33 PM
07/01/2008 6:33 PM
Joined: Nov 2003
Posts: 491
SoCal
S
sirdude Offline
Enthusiast
sirdude  Offline
Enthusiast
S

Joined: Nov 2003
Posts: 491
SoCal
ubbthreads is 2 space based, if you wanted it to match what it is using wink

but whatever fluffs your flannel is ok with me..

that's what powerful editors are for anyway. it's like a 2 command dealio in UltraEdit to change it from 4 to 2..

no biggie..

Re: [7.3.x] ubb.links [Re: sirdude] #317356
07/02/2008 8:07 AM
07/02/2008 8:07 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
I'm so glad I have your approval wink

I know this is not based on the zend framework, but I set my text editor up with the tabs based on their recommendations:

http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html

http://framework.zend.com/manual/en/coding-standard.coding-style.html

I know I have asked several times to pay someone to code this for me... I couldn't even pay for it so I'm doing it myself. Take up your spaces fetish with the zend people and let me know how it turns out. wink Or you could contribute to the project...


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317357
07/02/2008 10:30 AM
07/02/2008 10:30 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Minor version release to (hopefully) fix the html bug zarzal was seeing with subcats and sanitize the fave/rate submissions:

7.3.1a (released 7/2/2008):
- fixed xhtml issue with subcats
- added fave and rating submission sanitization

First post has latest code.


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317360
07/02/2008 11:58 AM
07/02/2008 11:58 AM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
Originally Posted by AllenAyres
Odd zarzal, not sure what to tell you. When you do a
SELECT * FROM ubbt_links_categories

does cat_order match up with what you are seeing in your links control panel?
seems so. I attach a result of the query as screenshot.
It looks that the sort follows cat_id if parrent_id = 0 and not cat_order

Attached Files
sortorder.jpg (6 downloads)
Last edited by Zarzal; 07/02/2008 12:00 PM.
Re: [7.3.x] ubb.links [Re: Zarzal] #317361
07/02/2008 12:35 PM
07/02/2008 12:35 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
I think I adjusted one SORT BY in the most recent version, can you upload the links.inc.php from the current zip and let me know if it fixed your html error and sort order? danke smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317362
07/02/2008 1:57 PM
07/02/2008 1:57 PM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
I already try the latest version, but no changes frown Can you change the sortorder on your system?
The html problem seems to be fixed. But right now I found a new layout problem: try pressing a green button near a link to edit it and see what happen ...

Last edited by Zarzal; 07/02/2008 2:00 PM.
Re: [7.3.x] ubb.links [Re: Zarzal] #317363
07/02/2008 2:33 PM
07/02/2008 2:33 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Yes, sort_order changes in my test install here:

https://www.ubbdev.com/forums/ubbthreads.php/ubb/links/op/Links.html

I fixed the layout on the edit screen, there's probably 1-2 more of those left... every screen had to be updated. smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317366
07/03/2008 9:32 AM
07/03/2008 9:32 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Please try the current zip Zarzal - maybe your combo of php/mysql didn't like the quotes in:

ORDER BY 'cat_order'

It should work either way, but maybe your case is special. smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317369
07/03/2008 2:59 PM
07/03/2008 2:59 PM
Joined: Jul 2001
Posts: 811
Berlin, Germany
Zarzal Offline
Coder
Zarzal  Offline
Coder

Joined: Jul 2001
Posts: 811
Berlin, Germany
no, this brings an error:
Parse error: syntax error, unexpected '}' in /var/www/users/d/d00003/websites/dragonclan-forum.de/board/scripts/links.inc.php on line 1090

/update:

aaahhhhh, the sortorder works. I insert the following block again that you have removed:
Code
function linkRating () {
    if ((!$row[totalvotes]) || (!$row[linkratingsummary])) {
    $average = 0;
    } else {
    $average = round(($row[linkratingsummary] / $row[totalvotes])-0,5);
    }
    $star = "";
    $stars = 0;
    while ($stars<$average) {
    	$star .= "<img src=\"{$config['BASE_URL']}/images/links/star.gif\" alt=\"{$ubbt_lang['LINKS_STAR']}\" border=\"0\" align=\"middle\" />";
    	$stars++;
    }
now te error is gone and the sortorder work

Last edited by Zarzal; 07/03/2008 3:02 PM.
Re: [7.3.x] ubb.links [Re: Zarzal] #317370
07/03/2008 5:15 PM
07/03/2008 5:15 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Well.... it looks like I left an extra } in there. It will be fixed on the next release. I'm glad at least we got past that bug on the sort. I'll make sure the other queries are updated too.


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317399
07/11/2008 3:24 PM
07/11/2008 3:24 PM
Joined: Jul 2008
Posts: 2
D
DoubleDutch Offline
Lurker
DoubleDutch  Offline
Lurker
D

Joined: Jul 2008
Posts: 2
It would be incredibly useful if we could define a Group that could moderate the links that was separate from the Administrators. Am I just overlooking this feature?

Re: [7.3.x] ubb.links [Re: DoubleDutch] #317403
07/12/2008 5:52 PM
07/12/2008 5:52 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
The moderators can moderate the links smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317409
07/15/2008 11:37 AM
07/15/2008 11:37 AM
Joined: Jul 2008
Posts: 2
D
DoubleDutch Offline
Lurker
DoubleDutch  Offline
Lurker
D

Joined: Jul 2008
Posts: 2
Right, but what if I don't want all of my moderators to moderate links, but only specific ones? Or specific groups of moderators?

Re: [7.3.x] ubb.links [Re: DoubleDutch] #317420
07/18/2008 4:09 PM
07/18/2008 4:09 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
That's a little over this mod so far... I'll look to get it into the next version tho smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: Zarzal] #317450
07/24/2008 5:30 AM
07/24/2008 5:30 AM
Joined: Dec 2007
Posts: 7
G
Grymmie Offline
Lurker
Grymmie  Offline
Lurker
G

Joined: Dec 2007
Posts: 7
I must be dumber than a skunk, but after downloading the zip file, I can not seem to find a method of "adding" ubblinks to my ubbthreads install.


Please advise with a little more substance for us "beginner" users.

Thanks

Re: [7.3.x] ubb.links [Re: Grymmie] #317451
07/24/2008 5:53 AM
07/24/2008 5:53 AM
Joined: Dec 2007
Posts: 7
G
Grymmie Offline
Lurker
Grymmie  Offline
Lurker
G

Joined: Dec 2007
Posts: 7
Woops...I guess I'm not that dumb after all.

Figured it out smile

Re: [7.3.x] ubb.links [Re: Grymmie] #317452
07/24/2008 6:48 AM
07/24/2008 6:48 AM
Joined: Dec 2007
Posts: 7
G
Grymmie Offline
Lurker
Grymmie  Offline
Lurker
G

Joined: Dec 2007
Posts: 7
Ok..now I have no clue..

Want to add a "Links" link to the breadcrumb bar. Guess its a new methodology vs 7.1 so I can not figure out how to do so.

Can someone advise?

Thanks

Re: [7.3.x] ubb.links [Re: Grymmie] #317453
07/24/2008 3:58 PM
07/24/2008 3:58 PM
Joined: Dec 2007
Posts: 7
G
Grymmie Offline
Lurker
Grymmie  Offline
Lurker
G

Joined: Dec 2007
Posts: 7
Ok,

I figured that out as well.

So now I know how to solve all my issues with UBBThreads.

First I try to make it work for days...
I give up in frustration...
I post on UBBDEV for an answer...
Then solve it myself, only AFTER posting on UBBDEV.

Hmmm....magical web site?

Re: [7.3.x] ubb.links [Re: Grymmie] #317454
07/24/2008 4:18 PM
07/24/2008 4:18 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Yes, we're magical smile

Sorry for not responding earlier, work has had me busy this week smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317459
07/26/2008 11:08 PM
07/26/2008 11:08 PM
Joined: Oct 2001
Posts: 135
New Mexico
Basil Fawlty Offline
Journeyman
Basil Fawlty  Offline
Journeyman

Joined: Oct 2001
Posts: 135
New Mexico
Allen,
I would like to try to install this, but not real clear on how to set up the tables. I'm running Threads 7.3. I gather I need to create the tables needed manually, but:

1) What tables are needed?
2) What are the fields and their properties for each table?


Re: [7.3.x] ubb.links [Re: Basil Fawlty] #317460
07/26/2008 11:24 PM
07/26/2008 11:24 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
hmmm... I need to update the original post to say that this is installed by the web now. You can access it directly by going to:

ubbthreads.php?ubb=links_install


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317461
07/27/2008 7:23 AM
07/27/2008 7:23 AM
Joined: Oct 2001
Posts: 135
New Mexico
Basil Fawlty Offline
Journeyman
Basil Fawlty  Offline
Journeyman

Joined: Oct 2001
Posts: 135
New Mexico
Thank Allen. I could have sworn I tried that, but will try again.

Re: [7.3.x] ubb.links [Re: Basil Fawlty] #317462
07/28/2008 12:17 AM
07/28/2008 12:17 AM
Joined: Oct 2001
Posts: 135
New Mexico
Basil Fawlty Offline
Journeyman
Basil Fawlty  Offline
Journeyman

Joined: Oct 2001
Posts: 135
New Mexico
Allen, thanks - I got it working! One question though. I can see how to "sort order" the man categories, but is there a way to also sort-order the sub-cats (other that manually from the database?)

Re: [7.3.x] ubb.links [Re: Basil Fawlty] #317465
07/28/2008 1:04 PM
07/28/2008 1:04 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
That's not how subcats were built way back when - the whole cats thing needs to be re-done to make it more flexible - could be simple-ish, but I need to dig some into the code smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #317513
08/22/2008 8:55 AM
08/22/2008 8:55 AM
Joined: Aug 2008
Posts: 4
M
Murphdog Offline
Lurker
Murphdog  Offline
Lurker
M

Joined: Aug 2008
Posts: 4
I tried installing this last night, and yes I was confused as to how to install it at first too but then figured that out, but I have 2 questions...

Are we suppose to create our own link somewhere on the site to administer or even just go to it?

Second, The layout was all jacked up when going to the main links page using the black and gold styles. I didn't even think about testing the default syles so I'm not sure if it is having the same issue with them.

I'm using 7.3.1, freshly installed this week with no other mods other than the black and gold style.

Last edited by Murphdog; 08/22/2008 8:56 AM.
Re: [7.3.x] ubb.links [Re: Murphdog] #317519
08/26/2008 8:57 AM
08/26/2008 8:57 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
The layout should be ok unless there's an issue with the style. I'd need to see it to find out. There's still some old code in there and it's possible a tbopen or tbclose was used without the proper corresponding tag.

You create links to it either in your overall site navigation, or in your forum's topnav template - that would be up to you to decide smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: Grymmie] #318369
12/17/2009 1:59 PM
12/17/2009 1:59 PM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
finally got around to installing this, this is great!

Re: [7.3.x] ubb.links [Re: badfrog] #318370
12/17/2009 2:08 PM
12/17/2009 2:08 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Glad you like it - tho there's a few options I'd loved to have added I think it works well for what it does smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #318371
12/17/2009 2:33 PM
12/17/2009 2:33 PM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
a feature that would be nice; notification of links waiting to be approved,

Re: [7.3.x] ubb.links [Re: badfrog] #318372
12/17/2009 2:35 PM
12/17/2009 2:35 PM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
I am noticing some odd CSS issues, like when I approve a link, or add a new category, the next page has a huge gap between my header and the links menu, I thought I was getting a blank page till I scrolled down.

Re: [7.3.x] ubb.links [Re: badfrog] #318373
12/17/2009 5:51 PM
12/17/2009 5:51 PM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
am I missing something? or is there no way to edit the links once they are approved? no way to delete them? correct spelling? update the link?

I see that it can be done for pending submissions, but not for anything previously approved.

I know squat about MySQL and have no clue how to edit in there.

Re: [7.3.x] ubb.links [Re: badfrog] #318374
12/17/2009 8:41 PM
12/17/2009 8:41 PM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
the CSS issues seem to be with the Koniro skin,
I just figured out what the red and green dots are next to a link!

Re: [7.3.x] ubb.links [Re: badfrog] #318375
12/17/2009 8:56 PM
12/17/2009 8:56 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
hehe, it's been a while since I've looked at the code, but I remember the red and green dots - they should do what you need smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #318380
12/18/2009 10:20 AM
12/18/2009 10:20 AM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
I have noticed when someone adds an ' to something, the script adds a \ before it.

so "you're" comes out like "you\'re"

Re: [7.3.x] ubb.links [Re: badfrog] #318384
12/19/2009 12:25 AM
12/19/2009 12:25 AM
Joined: Nov 2003
Posts: 491
SoCal
S
sirdude Offline
Enthusiast
sirdude  Offline
Enthusiast
S

Joined: Nov 2003
Posts: 491
SoCal
there is probably an addslashes without a stripslashes in the code..

Re: [7.3.x] ubb.links [Re: sirdude] #318385
12/19/2009 8:13 AM
12/19/2009 8:13 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Si, been a year or more since I've looked at the code smile

I may track down the offending addslashes and bug SD where to put the stripslashes smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #318386
12/19/2009 8:21 AM
12/19/2009 8:21 AM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
hehe, there's 4-5 addslashes and not one stripslash shocked


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #318388
12/19/2009 11:15 AM
12/19/2009 11:15 AM
Joined: Nov 2003
Posts: 491
SoCal
S
sirdude Offline
Enthusiast
sirdude  Offline
Enthusiast
S

Joined: Nov 2003
Posts: 491
SoCal
i can track it down for you allen... if you want.. just send me the latest code...

it's up to you.. you've done a fine job so far... nice addon! wink

Re: [7.3.x] ubb.links [Re: sirdude] #318398
12/19/2009 10:01 PM
12/19/2009 10:01 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Gracias SD - the first post here has the most current code. smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #318400
12/20/2009 12:05 PM
12/20/2009 12:05 PM
Joined: Nov 2003
Posts: 491
SoCal
S
sirdude Offline
Enthusiast
sirdude  Offline
Enthusiast
S

Joined: Nov 2003
Posts: 491
SoCal
Originally Posted by AllenAyres
Gracias SD - the first post here has the most current code. smile


ah, mah bad.. i'll d/l it and have a looksee.. smile

edit: ok.. dl'd it and the code is well commented, so i should be able to give this a go.. one thing is important to be added is to use mysql_real_escape_string to prevent malicious SQL baddies.. but overall, very good structure!! wink

I am aiming for 2 weeks (got a day job) to have a rev for your approval, Allen..

Re: [7.3.x] ubb.links [Re: sirdude] #318413
12/30/2009 8:10 PM
12/30/2009 8:10 PM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
I am getting an error when people try to follow any of the "latest links"

File not found: scripts/links_redirectphp.inc.php

Re: [7.3.x] ubb.links [Re: badfrog] #318414
12/30/2009 8:39 PM
12/30/2009 8:39 PM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
I fixed it!

line 643 in links.inc.php has an error,
search for
Code
make_ubb_url("ubb=links_redirect.php?lid=$row[lid]&amp;url=$row[url]
and replace it with
Code
make_ubb_url("ubb=links_redirect&amp;lid=$row[lid]&amp;url=$row[url]

Re: [7.3.x] ubb.links [Re: badfrog] #318415
12/30/2009 9:52 PM
12/30/2009 9:52 PM
Joined: Mar 2000
Posts: 25,587
Texas
AllenAyres Offline OP
I type Like navaho
AllenAyres  Offline OP
I type Like navaho

Joined: Mar 2000
Posts: 25,587
Texas
Merci BF - initial post updated with bugfix smile


- Allen wavey
- What Drives You?
Re: [7.3.x] ubb.links [Re: AllenAyres] #318962
12/04/2012 9:47 PM
12/04/2012 9:47 PM
Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
badfrog Offline
Power User
badfrog  Offline
Power User

Joined: Mar 2007
Posts: 94
somewhere on the coast of Main...
at some point in recent history, my links stopped parsing correctly, instead of passing you through to the URL (http://rollingheavymagazine.com),

it puts it all together like

/threads/ubbthreads.php/ubb/links_redirect/lid/198/url/http://rollingheavymagazine.com

I have no idea how long this has been happening.....

Page 1 of 3 1 2 3

Donate Today!
Donate via PayPal

Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.

Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
Recommended Hosts
We have personally worked with, and recommend, the following Web Hosts:
· Stable Host
· Blue Host
· Interserver.net
Visit us on Facebook
Member Spotlight
Bill B
Bill B
Issaquah, WA
Posts: 84
Joined: December 2001
Show All Member Profiles 
Forum Statistics
Forums64
Topics37,466
Posts293,522
Members13,801
Most Online1,498
Mar 17th, 2017
Top Posters(All Time)
AllenAyres 25,587
JoshPet 11,330
Rick 8,373
LK 7,396
Lord Dexter 6,503
Gizmo 5,947
Greg Hard 5,533
Top Posters(30 Days)
isaac 1
Today's Statistics
Currently Online 811
Topics Created 0
Posts Made 0
Users Online 0
Birthdays 10
The UBB.Developers Network (UBB.Dev/Threads.Dev) is ©2000-2018 VNC Web Services

 
Powered by UBB.threads™ PHP Forum Software 7.7.0
(Snapshot build 20181115.dev)
PHP: 5.4.45 Page Time: 0.128s Queries: 20 (0.018s) Memory: 3.9734 MB (Peak: 4.8314 MB) Data Comp: Zlib Server Time: 2018-12-11 09:59:27 UTC