Previous Thread
Next Thread
Print Thread
Rate Thread
#313431 03/08/2007 12:31 AM
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki Owner
Time Lord
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
Some users experience problems with avatars, if you set the max height and width and there isn't one associated with an avatar, it'll skew them from loading. If you don't set a max height and width it'll display them as a 1x dot in IE...

The only *real* fix for this, is to not specify a height and width when loading the avatars...

This should be rather quick to do, and only short script mods. I will be updating this thread periodically when I notice other pages it needs applied to; so check back!

Thread Viewing, Flat View
edit scripts/showflat.inc.php
Find:
Code
				$postrow[$i]['Picture'] = "<img src=\"$Picture\" alt=\"\" $picsize />";

Replace With:
Code
				$postrow[$i]['Picture'] = "<img src=\"$Picture\" alt=\"\" />";

Show Thread, Threaded View
Edit scripts/showthreaded.inc.php
Code
			$Picture = "<img src=\"$Picture\" alt=\"\" $picsize />";

Replace With:
Code
			$Picture = "<img src=\"$Picture\" alt=\"\" />";


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, My UBB Scripts
Sponsored Links
Joined: May 2001
Posts: 794
Content Queen
Content Queen
Offline
Joined: May 2001
Posts: 794
Gizzy is my hero!

Thank YOU!

And my community thanks you! smile


Sue
adwoff.com
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki Owner
Time Lord
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
hehehe...

BTW, I looked at the showprofile and userlist sections where the avatars are loaded, but they don't seem to specify a size; so those pages should be exempt from any editing afaik.


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, My UBB Scripts
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Offline
Joined: Jul 2006
Posts: 21
Actually, they do use the size function.

FYI, this only stops the pages from specifying the size, but it doesn't really fix the problem. When you take this out the avatars can be ANY size, which isn't good.

The solution here would be to change the getimagesize function (when I find it) and alter it to work properly.

I have a mod that did this properly and I can probably port the code pretty easily if I can find how/where to make the changes.

Fred

Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Offline
Joined: Jul 2006
Posts: 21
I found the problem/solution. It is a simple typo in the changebasic.inc.php file (in /scripts).

I outlined the change here: UBBCentral

For everyone that doesn't want to click on the link (and have to scroll down)...

Find:
Code
$imagehw = getimagesize("{$config['UPLOADED_AVATAR_URL']}/$Picturefile");

Replace with:
Code
$imagehw = getimagesize("{$config['UPLOADED_AVATAR_PATH']}/$Picturefile");

Basically it is a typo, changing 'UPLOADED_AVATAR_URL to 'UPLOADED_AVATAR_PATH.

Change this 1 line, resave the file and your gold, no need to change or remove any of the size stuff anywhere else.

Edit: One last thing, this only fixes the future avatars, any that are currently uploaded by the users need to be reuploaded. This is because a size of 80x80 is already "set" in the user database because with the typo it couldn't "find" the file to check for file sizes so it put the max (80x80). Having the users reupload their avatars after you make this change will correct it.

Last edited by Fred Johnson; 03/20/2007 3:57 PM.
Sponsored Links
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki Owner
Time Lord
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
A good comprimise would be to apply both mods and leave the max avitar height and width set so future avitars do not go above them.


UBB.Dev - Putting Dev into UBB.threads
Company: VNC Web Services - UBB.threads Scripts and Scripting, Install and Upgrade Services, Site and Server Maintenance.
Forums: A Gardeners Forum, Scouters World, and UGN Security
UBB.Threads: My UBB Themes, My UBB Scripts
Joined: Nov 2003
Posts: 482
Enthusiast
Enthusiast
Offline
Joined: Nov 2003
Posts: 482
viewmessage.inc.php is affected as well with $picsize being set.

just an fyi wink


Link Copied to Clipboard
Donate Today!
Donate via PayPal

Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.

Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
Recommended Hosts
We have personally worked with and recommend the following Web Hosts:
Stable Host
bluehost
InterServer
Visit us on Facebook
Member Spotlight
Bill B
Bill B
Issaquah, WA
Posts: 87
Joined: December 2001
Forum Statistics
Forums63
Topics37,573
Posts293,925
Members13,849
Most Online5,166
Sep 15th, 2019
Today's Statistics
Currently Online
Topics Created
Posts Made
Users Online
Birthdays
Top Posters
AllenAyres 21,079
JoshPet 10,369
LK 7,394
Lord Dexter 6,708
Gizmo 5,833
Greg Hard 4,625
Top Posters(30 Days)
Top Likes Received
isaac 82
Gizmo 20
Brett 7
WebGuy 2
Morgan 2
Top Likes Received (30 Days)
None yet
The UBB.Developers Network (UBB.Dev/Threads.Dev) is ©2000-2024 VNC Web Services

 
Powered by UBB.threads™ PHP Forum Software 8.0.0
(Preview build 20221218)