UBB.Developers Forums UBB.threads 6 V6 Modifications Templates [6.3] Facelift for UBB Threads

I've heavily edited the showflat.tmpl file. I used BeyondCompare, and I believe this is the new section:



Is this correct?

Thanks DLT

Look at the poll results. I think there needs to be a colspan="2" in the tdheader.

Dal - if you're including my icon thing in this now too - be sure to add this additional step to modifypost.php. It'll fix the missing icon thing.

https://www.ubbdev.com/forum/showthreaded.php?Number=88905

[]JoshPet said:
Look at the poll results. I think there needs to be a colspan="2" in the tdheader. [/]

Yep -I'll fix that soon Mr. Bug

[]JoshPet said:
Dal - if you're including my icon thing in this now too - be sure to add this additional step to modifypost.php. It'll fix the missing icon thing.

https://www.ubbdev.com/forum/showthreaded.php?Number=88905 [/]

-thanks!

[]dimopoulos said:
Thanks DLT [/]

Anytime

Yep -that's it

This seems to add the edit button to moved threads. Does it not do it for closed threads as well?

In a closed thread, I have a reply button, and it takes me to my profile. Why would a closed thread have a reply button?

DLT...Under the facelift, I just noticed that if I, as admin, go to edit a post by some other user, the edit form seems to have some things missing from the standard edit form. In particular, there is no check box to select whether or not to show as edited, and the box for checking whether or not to preview the edited version is to the RIGHT of the text area, rather than underneath.

Of course, it is possible I have a corrupted file for this template. but I don't see how that would have happened, since I haven't touched it, and I still can't figure out what templates control most of the stuff, anyway.

(Boy, it would sure help to have a guide to what templates control what on the various pages!!!!!)

Anyway, I'd appreciate it if you, or someone else, could have a look at what happens if you try to edit someone else's post!

Thanks - Tony

The check box is there for me and I'm using DLT's. You may have to reinstall the hack if you're talking about it appearing with other members' posts.

I'll have to test that out on my dev site -it may take a little while because I'm working in an area where I don't have Internet acces after work...

No....Internet.......access???

DLT: I've been trying to figure out a couple of irregularities on my site with "facelift", one of which I posted earlier and still haven't figured out (regarding the form for editing a user's post), but there's another ambiguity with regard to (at least MY reading of) the instructions on YASM and facelift. You say:
"When you install YASM you only need to follow the instructions for editing your dosearch.php file (I've included the template that you need for YASM)."

However - and this is fairly obvious to an experienced user, but perhaps not others - you still need to edit and upload the search.php in the language file (as I discovered when I found there was no language associated with the new search options). Maybe you ought to add a reference to changing the associated language file. Also...there are TWO templates edited under YASM (search and dosearch), so maybe you ought to change the word "template" in the instruction I've cited to "templates".

Anyway, I thought that in these 2 respects the language regarding YASM wasn't too clear, and you might want to change it.

Thanks - Tony

(As to my problem with the form for editing a user's post, I guess I'll just upload the current set of templates, and see if things work.)

Thanks - Tony

I reinstalled the current set of templates, and that form still has the problem!

It's the one you get when as administrator, you hit "edit" for a user's post (that is, not your own).

If I knew the name of the template, I could probably identify the problem myself, but one of the problems with all the templates is that it's difficult to figure out what does what!!!!

Further suggestions would be welcome! Thanks - Tony

His mod requires YASM (Yet another search mod) available for download here under modifications. However I don't think this search page mod is working quite right for 6.3. I know it's not working quite right here - particularly when you search for a user name.

The template you are looking for is editpost_nopoll.tmpl

The templates generally have the same name as the script (editpost.php) but because of polls there are 2 versions of it..... as you can't edit polls. So editing a regular post (without a poll in it) would be editpost_nopoll.tmpl

thanks for the info, Josh, and - when I opened that template in the admin editor - I found what seems to be an elision (is that the right word?), as though two sections of code, one for the mark as edit and the other for preview, had been run together, with effectively a whole section missing.

Just to test, I added a line break after the section of code for the post box, because there was a little check box at the SIDE of the big box for the post, rather than under it. My change put the check box under the post box, with the text "I want to preview my modifications and add or edit an attachment."

But there IS no check box or text for selecting whether or not to mark the post as edited, and I think there should be!

What do you think? Tony

EDIT: I've stared at the template a bit more, and I think my remark about the elision is wrong. BUT the fact remains that the check box was to the right at the post box (which my line break fixed), AND there is no mark as edited option when I (as administrator) go to edit a user's post. (Would there be a difference if I went as moderator? For the case I tried, I'm both...) But the mark as edited option IS there if I (as admin) edit one of my own posts!

Any word on being able to edit closed threads?

I've fixed it here - let me figure out what I did to a standard template and post it.

I dunno if this is it.

Ours has alot more stuff - see if the attached fixes it (but save your old one if it breaks you can put it back. )

I manged to hack around and get the edit back for closed topics. It's not the prettiest looking thing in the world, and now there are 2 edit buttons for moved threads, but at least it works! Only moderators and I can see them, and with 6.4 that stuff is going to be moved anyway.

Thanks!

Hi...I just noticed an extraneous line of text above the footer on the showflat screen that says:

"Open = O Edit link ="

and as far as I can tell it's associated with a couple of lines of code added at the bottom of the 7/11 showflat.tmpl (if I upload the 7/2 showflat template, the extraneous text goes away)

It's no biggie, of course, but I'm curious if there is a simple fix.

Thanks Tony

Are you talking about showflat.tmpl dated 7/11 in the zip file? I don't see what you're talking about in there.

yes, that is the template I'm talking about.

My board uses facelift, and I just noticed that at the bottom of the showflat page, there is some extraneous text that appears, outside any of the usual tables, and just before the footer. It reads:

"Open = O Edit link ="

This text is not there when I use the older showflat template, and appears (tto me)to be somehow associated with code added in the 7/11 showflat.tmpl, namely these two lines near the end:

Open = $Open
Edit link = {$postrow[$i]['editlinkstart']}

...which I presume have to do with the editing option Dal was adding.

Any idea how these could lead to the extraneous text? If YOU are using the facelift, have you not noticed this text?

Always possible, of course, that I have something ELSE wrong with my board, but thought I'd check about the obvious link between that text and these 2 lines of code.

Thanks! Tony

Actually, I do think I remember seeing this. I am trying to look at my tmpl file now, but I can't FTP into my account at the moment.

What is the URL to your site?

here's my test board Check out any showflat page near the bottom.

Thanks - Tony

I just noticed it's still on mine! I don't know why they're there, but here's how to fix it:

Find this:


Change to this:


I don't know what that code is there for. I also don't know why it doesn't show up here. Maybe someone will come along and enlighten us.

Well, it was evidently added in connection with:

"2003-July-11 Fixed a bug in the showflat.tmpl and showthreaded.tmpl files that prevented editing the pointers for moved posts. "

...to quote Dal re his last change to the "facelift")

Isn't it about this that you and others were talking above in the not too distant past?

Tony

Dal should be back the 18th.... and hopefully get this tuned back up.

it be the 23rd

Doah!

Poor Dal. I miss him.

My custom post icons don't show up for some reason. I can still view them in admin but they aren't an option in the drop down menu.

Also, I noticed the same problem as TonyN did when editing a post. I know that suppressing edit for someone else's post is not a default option but the preview check box to the right of the text box is in the zip that I downloaded the other day.

For the icons.... did you make changes to the addpost.php script?

addpost.php has been modified for Quickreply and Instant Subscriptions.

View the source where youa re missing an icon and see what value it's got for the Icon.

[]TonyN said:
Well, it was evidently added in connection with:

"2003-July-11 Fixed a bug in the showflat.tmpl and showthreaded.tmpl files that prevented editing the pointers for moved posts. "

...to quote Dal re his last change to the "facelift")

Isn't it about this that you and others were talking above in the not too distant past?

Tony [/]

Sorry, I was doing some testing on the variables and I had echoed them out at the bottom of the script to see what their values were. I fixed the showflat.tmpl file and updated the zip file in the first post.

When viewing the source this is what I see for post icons:

<a href="https://www.theiconsortium.com/iBASE/showicons.php?Cat=" target="new">Post Icon</a>

<br />
<select name="Icon" class="formboxes">
<option value="blush.gif" >blush</option>
<option value="chat.gif" >chat</option>
<option value="cool.gif" >cool</option>
<option value="crazy.gif" >crazy</option>
<option value="exclamation.gif" >exclamation</option>
<option value="disk.gif" >file</option>
<option value="frown.gif" >frown</option>
<option value="lightbulb.gif" >idea</option>

<option value="laugh.gif" >laugh</option>
<option value="link.gif" >link</option>
<option value="mad.gif" >mad</option>
<option value="book.gif" selected="selected" checked="checked">note</option>
<option value="poll.gif" >poll</option>
<option value="question.gif" >question</option>
<option value="ribbon.gif" >ribbon</option>
<option value="shocked.gif" >shocked</option>
<option value="smile.gif" >smile</option>

<option value="tongue.gif" >tongue</option>
<option value="trophy.gif" >trophy</option>
<option value="wink.gif" >wink</option>
</select>
<br />

My custom icons aren't listed in there. When I edit a post that had a custom icon there is no way for me to keep that custom icon.

These is the changes I made for Quick Reply:

" $Icon = get_input(""Icon"",""post"");
// strip off the URL
$Icon = basename($Icon);"

Replacing: $Icon = get_input("Icon","post");


" $PStatus = get_input(""PStatus"",""post"");
$dofav = get_input(""dofav"",""post"");
$quickreply = get_input(""quickreply"",""post"");

// -----------------
// If it came from the quick reply form
// we need to grab the ParentUser number for the reply
if (($quickreply) && (!$ParentUser)) {
$query = ""
SELECT B_PosterId
FROM {$config['tbprefix']}Posts
WHERE B_Number = $Parent
"";
$sth = $dbh -> do_query($query);
list($ParentUser) = $dbh -> fetch_array($sth);
} "

"Replacing:
$PStatus = get_input(""PStatus"",""post"");
$dofav = get_input(""dofav"",""post"");"


if ( (preg_match("/^\s*$/",$Subject)) || ($Body == "") || ($Body == " ") || ($Body == " ") || ($postername == "") ) {

"Replacing:
if ( (preg_match(""/^\s*$/"",$Subject)) || ($Body == """") || ($postername == """") ) {"


This is the change for Instant subscription:

"// Send an Email to the Subscribers if they are Subscribed to this board
if (($Approved == ""yes"") && ($config['subscriptions'] == 1))
{
$query = ""
SELECT U_Email,
U_Language
FROM {$config['tbprefix']}Users
LEFT JOIN {$config['tbprefix']}Subscribe ON S_UID = U_Number
WHERE S_UID = U_Number
AND S_Board = '$Board_q'
"";

$sth = $dbh -> do_query($query);

while ( list($Mailto,$Language) = $dbh -> fetch_array($sth) )
{
// -------------------------------------------=
// We need to make sure this user still exists
if ($Mailto) {

// -----------------------------------------------------------------
// Now if this user has a pre-selected language we use that language
// for the message we send out
if (!$Language) { $Language = $config['language']; }

require ""{$config['path']}/languages/$Language/addpost.php"";

$EmailBody = $Body;
if ($config['stripcodes']) { $EmailBody = preg_replace(""/<([^>])*>/"","""",$EmailBody); }
$EmailBody = eregi_replace(""<br />"", ""\r\n"", $EmailBody);

$newline = ""\n"";
if (stristr(PHP_OS,""win"")) { $newline = ""\r\n""; }

$to = $Mailto;
$mailer = new mailer;
$header = $mailer -> headers();
$subject = ""New Post To $Title from $postername"";
$msg = ""$postername has posted a message to $Title: $newline{$config['phpurl']}/showthreaded.php?Cat=$Cat&Board=$Board&Number=$Mnumber$newline${newline}------Message Below------${newline}Subject: $FormSubject${newline}${newline}Message:$newline$EmailBody"";

mail(""$to"",""$subject"",$msg,$header);

// --------------------------------------------------
// Now, we need to switch back to this users language
$Language = $user['U_Language'];
if (!$Language) { $Language = $config['language']; }
require ""{$config['path']}/languages/$Language/addpost.php"";
}
}
}"

"above:
// ---------------------------------------------
// Update the total post if the post is Approved"


Otherwise my addpost.php is stock and I don't see how these changes would affect whether or not custom icons are shown.

I'm thinking that Dal doesn't have all of my mod incorporated into this... the pull down menu should contain the full URL to the icon (and not just the icon name). That's the only way the preview thing works, and why I had to add code to strip it off in addpost.php

Plus it looks more like the standard pulldown alternat template in threads, as it's not doing the custom icons, and I handle the default selection a bit differently.

Try using the files in the actual mod and that should fix it.

https://www.ubbdev.com/forum/showflat.php?Board=modifications&Number=84789

[]JoshPet said:
I'm thinking that Dal doesn't have all of my mod incorporated into this...

/ -snip- /

Plus it looks more like the standard pulldown alternat template in threads, [/]

Yup, I used the alternate template in Facelift. In order to make Facelift a "download and install" mod I couldn't include anything that altered a standard Threads php file. Granted I have a couple of php files listed in the prerequisites, but they are not mandatory. In fact YASM hasn't worked since 6.3 -and I'm not sure how to fix it.

The next version of Facelift (for Threads 6.4) will contain no prerequisites and no php file editing (just download and copy to your server).