Previous Thread
Next Thread
Print Thread
Rating: 5
Page 10 of 11 1 2 8 9 10 11
Joined: Aug 2004
Posts: 173
D
Member
Offline
Member
D
Joined: Aug 2004
Posts: 173
[]AllenAyres said:
I can look at this for you if you like, it's probably easy, tho I'm not sure... been a while since I looked at the code. [/]

Thanks Allen

Sponsored Links
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Untested:

OPEN links_admin.php

FIND:

Code
<br />// -----------------------------<br />// Make sure they should be here<br />   if (($user['U_Status'] != 'Administrator') && ($user['U_Status'] != 'Moderator')) {<br />      $html -> not_right ("You must be logged in, and be a valid administrator to access this.",$Cat);<br />   }<br />


REPLACE WITH:

Code
<br />// -----------------------------<br />// Make sure they should be here<br />   if (($user['U_Status'] != 'Administrator')) {<br />      $html -> not_right ("You must be logged in, and be a valid administrator to access this.",$Cat);<br />   }<br />


- Allen wavey
- What Drives You?
Joined: Aug 2004
Posts: 173
D
Member
Offline
Member
D
Joined: Aug 2004
Posts: 173
Thanks Allen, I will try that when I get home and let you know

Joined: Aug 2004
Posts: 173
D
Member
Offline
Member
D
Joined: Aug 2004
Posts: 173
Bit late of me

This works fine, thanks Allen

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
glad it worked for you


- Allen wavey
- What Drives You?
Sponsored Links
Joined: Nov 2001
Posts: 134
M
Journeyman
Offline
Journeyman
M
Joined: Nov 2001
Posts: 134
I'm not getting a setup screen which I think I should be?

Instead I get

Script:
Line#:
SQL Error: select command denied to user: '[email protected]' for table 'w3t_links_links'
SQL Error #: 1142
Query: SELECT lid,cat_id FROM w3t_links_links WHERE approved = '1'

Please use your back button to return to the previous page.

Joined: Nov 2001
Posts: 134
M
Journeyman
Offline
Journeyman
M
Joined: Nov 2001
Posts: 134
Ok ive created the tables manually and its working now, although not sure why i didnt get the admin menu asking me to install and create all these?

Joined: Nov 2001
Posts: 134
M
Journeyman
Offline
Journeyman
M
Joined: Nov 2001
Posts: 134
Ah, another problem.. when submitted a new link I get

Warning: mail(): SMTP server response: 501 5.5.4 Invalid Address in g:\webs\www.bm3w.co.uk\public_html\ubbthreads\links_submit_link.php on line 93
Could not notify admin

Do we need to set an address somewhere?

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Sorry Matt, on holiday. I'll check it out when I'm back home and have access to my computer (1-2 days)


- Allen wavey
- What Drives You?
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
[]MattUK said:
Ah, another problem.. when submitted a new link I get

Warning: mail(): SMTP server response: 501 5.5.4 Invalid Address in g:\webs\www.bm3w.co.uk\public_html\ubbthreads\links_submit_link.php on line 93
Could not notify admin

Do we need to set an address somewhere? [/]

It uses the forum's email address set in the control panel. Double-check that your forum's email address is a current legit one.


- Allen wavey
- What Drives You?
Sponsored Links
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Download zip updated to 1.8.3 - a few bugs fixed


One was in the links admin where the admin viewed links submitted, the link to the username didn't work, now it does


- Allen wavey
- What Drives You?
Joined: Jul 2001
Posts: 808
Coder
Offline
Coder
Joined: Jul 2001
Posts: 808
Thank you for this Update. The V1.83 is the first version behond 1.5 that will work on my server. But the are 2 typo bugs in links_submitrate_link.php
On Line 39 and 59 you must add \ to the " around the word top or you get an error while trying to rate a link.

Good work !

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Thanks for the bugfixes, download zip is updated in the first post


- Allen wavey
- What Drives You?
Joined: Oct 2001
Posts: 27
User
Offline
User
Joined: Oct 2001
Posts: 27
This mod adds search capability to TLD. Links title and description are searched and the found search term is bolded. Perhaps Allen or Josh would be so kind as to integrate my changes into the latest and greatest release because my changes may not include those contributed by other users since I last worked on this script. The integration should be minor because I only changed one script and one template. Enjoy.

Files:

links_search_links.php (new script to go with your other links scripts)
links.php (you may need to modify the path to links_search_links.php)
links_header.tmpl (this replaces links_header.tmpl in your templates/default directory)
search.gif (new icon - this goes in your images directory)

Attached Images
128790-TLDLinks.zip (0 Bytes, 253 downloads)
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
cool, I'll get it integrated sometime this week and release it as a 2.0


thankyou again


- Allen wavey
- What Drives You?
Joined: Oct 2001
Posts: 27
User
Offline
User
Joined: Oct 2001
Posts: 27
Added a couple of minor fixes:

Added 'no results found' message, previously no message which made you wonder if the script was working.

When bolding search results, script wasn't retaining case. Example: search for 'dallas' would return 'dallas' but it should have returned 'Dallas'.

Links no longer send the URL in the clear.

Attached Images
128875-links_search_links.zip (0 Bytes, 244 downloads)
Last edited by ekempter; 07/31/2005 12:24 AM.
Joined: Oct 2001
Posts: 27
User
Offline
User
Joined: Oct 2001
Posts: 27
[]ekempter said:

3. Added a configurable option to specify the minimum number of votes required before a link will appear on the Top Rated page and before the 'stars' ratings will appear next to a link.
[/]

The stars appear in the 'Most Popular' list regardless of how the configuration option is set. Fixed this. Allen, please integrate into the lastest release - this is a very small mod.

Thanks.

Attached Images
128876-links_popular_links.zip (0 Bytes, 286 downloads)
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
will do - thank you


- Allen wavey
- What Drives You?
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Zip files updated with the search feature by ekempter -

A few small bugfixes to update it to work with threads 6.5+ and a url fix.

Thanks ekempter, seems to be working real well here


- Allen wavey
- What Drives You?
Joined: Jul 2001
Posts: 808
Coder
Offline
Coder
Joined: Jul 2001
Posts: 808
Thank you for this update.

After review the files your should take a look to links_popular_links.php
The header contains wrong version descriptions and in line 58 is an alt tag missing after /images/popular-c.gif\ witch was in your last update.

I have a question about your directory structure for this modification. I put he language files in the UBBt language directory so I have to edit the line

require ("languages/{$myprefs['language']}/links.php");
to
require ("./languages/{$myprefs['language']}/links.php");

in some files. There should be a note in the installation description about the directory location.

This update works very well.

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
thanks for the bug report, I'll update this this coming weekend with the fixes and look at the language issue too.


- Allen wavey
- What Drives You?
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Fixed the alt text buglet there and in one other place - zip updated. I don't have an answer for the languages issue yet.


- Allen wavey
- What Drives You?
Joined: Mar 2000
Posts: 528
M
Junior Member
Offline
Junior Member
M
Joined: Mar 2000
Posts: 528
OK Gents - quick question.

I have never used TLD...and basically all I need is an online script that will handle my bookmarks. I get tired of using multiple PCs and managing the bookmarks on each, so I am going to start using my personal site to do so. Easy enough to lock away if I need.

My question is this - should I install this mod on my family's threads site and use it for my personal use, or is this a bit 'robust' for one user? I am sure there are a bunch of random non-integrated bookmark scripts out there, but figured I would start here.

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
this one is pretty simple to setup, bookmarks would probably be a good use for it


- Allen wavey
- What Drives You?
Joined: Feb 2001
Posts: 2,268
D
Junior Member
Offline
Junior Member
D
Joined: Feb 2001
Posts: 2,268
I just added this one to my site (after manually creating the tables). I can't get it to work -every time I submit a link I get:

You have not filled out the form completely. Please hit your back button and try again.

After digging through the scripts that erro is triggered in the links_submit_links.php file by the following code:

Code
 // Check to see if the form was filled out completely <br /> <br />	if (!filled_out($HTTP_POST_VARS)) { <br />		print "<center><b>{$ubbt_lang['LINKS_SUBMIT_FILLED_OUT']}</b></center>"; <br />		$html -> send_footer(); <br />		exit; <br />	} 


It looks like the function that checks to see if all of the $HTTP_POST_VARS are avaialble is failing. Any ideas?

Last edited by Dalantech; 08/12/2005 11:51 AM.
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
good question, it could be that we should be using the same sub threads uses for form submissions


- Allen wavey
- What Drives You?
Joined: Feb 2001
Posts: 2,268
D
Junior Member
Offline
Junior Member
D
Joined: Feb 2001
Posts: 2,268
Allen please post the scripts that Threads Dev is using for this hack so I can use Beyond Compare to see what the differences are between the scripts that work here, and the ones in the mod.

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
we're using the same scripts you find in the first post in this topic. I updated them here when I updated the zips.


- Allen wavey
- What Drives You?
Joined: Feb 2001
Posts: 2,268
D
Junior Member
Offline
Junior Member
D
Joined: Feb 2001
Posts: 2,268

Joined: Feb 2001
Posts: 2,268
D
Junior Member
Offline
Junior Member
D
Joined: Feb 2001
Posts: 2,268
The check to see if all of the form data is filled in fails on my site: as written it's always evaluates to false.

Code
 function filled_out($form_vars)<br />	{<br />	// lets make sure that each variable has a value<br />	foreach ($form_vars as $key => $value)<br />		{<br />		if (!isset($key) || ($value == ""))<br />			return false;<br />		}<br />		return true;<br />	} 


I can re-write the function to get it to return true, but then I can't get it to fail when a form isn't filled in...

Joined: Feb 2001
Posts: 2,268
D
Junior Member
Offline
Junior Member
D
Joined: Feb 2001
Posts: 2,268
I finally figured out how to fix it -it's not pretty but it works. Since there are only 4 variables that are user selectable I decided to only check for those 4:

Code
 foreach ($HTTP_POST_VARS as $key => $value);<br /><br />// Check to see if the form was filled out completely<br />if ( (!isset($cat_id) || ($cat_id == "")) || (!isset($url) || ($url == "")) || (!isset($title) || ($title == "")) || (!isset($description) || ($description == "")) ) {<br />		print "<center><b>{$ubbt_lang['LINKS_SUBMIT_FILLED_OUT']}</b></center>";<br />		$html -> send_footer();<br />		exit;<br />	} else { 


After the else the rest of the script to check the url and enter the data in the database executes.

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
thanks, that's a new bug not reported before. You must be running a slightly different server setup - is it windows IIS or something?


- Allen wavey
- What Drives You?
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Original post updated with zip to work with 6.5.2 plus some small bugfixes


- Allen wavey
- What Drives You?
Joined: Jul 2001
Posts: 808
Coder
Offline
Coder
Joined: Jul 2001
Posts: 808
my provider changed the webserver a little bit and my TLD2 stop working correct in some functions. It doesnt show any error.

I can enter the main page of TLD. All looks nice and correct. If I click on a category it goes to it but show only every time the same link only (only one and every time the same). It doesn't show me the correct content of the category.

I can click on what I like, I get every time the same result showing me the one and only link and the categorys. The DB contains 138 Links.

Click I 'Most Popular' I see some of my links. If I try to follow a link the redirector show me an empty page (in firefox). In IE it take me back to my board main index.

I try do delete one of the Most Popular links, got the correct message that this link is deleted but after I revisit Most Popular it is still intact and I have 138 links.

If I try to edit a category or link I get the error that not all is filled out correctly.

I can remeber that this problem have to do with global variables or something like this. Anyone who know this effect and have a solution? I like TLD and have to bring it to work again. I need some help.

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
hmm.. got a link? And did the hosts say what they changed?


- Allen wavey
- What Drives You?
Joined: Jul 2001
Posts: 808
Coder
Offline
Coder
Joined: Jul 2001
Posts: 808
The host changes everything smile he replace the servermachine include the server software. From Zeus to Lightspeed.

You can take a look on my board on http://www.dragonclan-forum.de/ubbthreads/links.php

But you have to register to access this page.

Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
Strange, have you tried visiting the links admin page and submitting anything?


- Allen wavey
- What Drives You?
Joined: Jul 2001
Posts: 808
Coder
Offline
Coder
Joined: Jul 2001
Posts: 808
If I try to submit a link I get: http:// is not a valid url or is temporarily unavailable. Please check the url by clicking on the link and try again.

Seems be related to the post/get bug from Dalantech and maybe Threads 6.5.5 .... I changed the threads version von 6.5.4 to 6.5.5 some days bevore the server changes and not test the TLD *shame*.

/edit: I try to apply the fix for links_submit_link.php from dalantech above, but I ancounter some problems ... still working and cant find out to put it in the right place.

Last edited by Zarzal; 07/26/2006 2:56 PM.
Joined: Jul 2001
Posts: 808
Coder
Offline
Coder
Joined: Jul 2001
Posts: 808
Update: I m on the way. I compare V1.5 to V2.0 and bring some old sript parts to V2. It begins to work but I guess its realy unsafe to XSS. The Links Categories shows now correect, but there is alot more work to do.

/edit: I include in most cases some code like this (example redirector):
PHP Code
 $lid = get_input("lid","get");
$url = get_input("url","get");


Index works, showlinks work, redirector work. I work on the rest

Last edited by Zarzal; 07/26/2006 3:34 PM.
Joined: Mar 2000
Posts: 21,079
Likes: 3
I type Like navaho
Offline
I type Like navaho
Joined: Mar 2000
Posts: 21,079
Likes: 3
good deal smile


- Allen wavey
- What Drives You?
Page 10 of 11 1 2 8 9 10 11

Link Copied to Clipboard
Donate Today!
Donate via PayPal

Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.

Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
Recommended Hosts
We have personally worked with and recommend the following Web Hosts:
Stable Host
bluehost
InterServer
Visit us on Facebook
Member Spotlight
Posts: 70
Joined: January 2007
Forum Statistics
Forums63
Topics37,555
Posts293,845
Members13,842
Most Online5,166
Sep 15th, 2019
Today's Statistics
Currently Online 515
Topics Created 0
Posts Made 0
Users Online 0
Birthdays 9
Top Posters
AllenAyres 21,079
JoshPet 10,369
LK 7,394
Lord Dexter 6,708
Gizmo 5,813
Greg Hard 4,625
Top Posters(30 Days)
Morgan 3
isaac 2
Top Likes Received
isaac 69
Gizmo 13
Brett 7
WebGuy 2
Morgan 2
Top Likes Received (30 Days)
isaac 3
The UBB.Developers Network (UBB.Dev/Threads.Dev) is ©2000-2021 VNC Web Services

 
Powered by UBB.threads™ PHP Forum Software 8.0.0
(Snapshot build 20201211)
Responsive Width:

PHP: 5.4.45 Page Time: 0.183s Queries: 99 (0.092s) Memory: 3.6875 MB (Peak: 4.1342 MB) Data Comp: Zlib Server Time: 2021-05-09 13:30:07 UTC
Valid HTML 5 and Valid CSS