|
|
Joined: Jan 2003
Posts: 3,456 Likes: 2
Master Hacker
|
|
Master Hacker
Joined: Jan 2003
Posts: 3,456 Likes: 2 |
quote: Originally posted by Gizzy: I found an, odd, bug...
When you view the script here and compaire it to my forum #6 it pretty much pick and chooses which stories it wants to use...It's based on when the topic is made, not when it was last replied to. Look at the links, it's t=290,291,292,etc
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
You know, i figured that AFTER i actually glanced through the posts lol...
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Yeah...I should probably add some error handling in it to quelch the ugly errors...
The nice thing is the .threads for private forums are tucked away in the private directory. Not to meniton it would require opening vars_forums.cgi, and doing an authentication check before displaying anything. Can get just plain ugly at that point.
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Here's a patch to cure that and a missing .threads error Before $thread_data = file($threadspath); Add if (file_exists($threadspath)) {and After Insert } else {
$thr_array = 0;
echo "Unable to read .threads file. Either you are trying to access a private forum, or you need to Rebuild your forum stat files.";
}I'll upload a patched zip shortly.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
I have an error :x.. When users use in a post, and it's set to trunicate the posts after so many characters it displays the rest as quoted since the ending of the quoted text was trunicated. http://www.undergroundnews.com/ubbnews.php?forum=6&threads=5
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
I'll add it to the known issue list.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
Found another: When there is only one forum and the requested is 5, it errors out, granted that there is no data for it to retrieve... quote:
Posted by
Posted:
Read More...
Comments (-1)
Warning: file(/var/www/html/ubb/Forum26/.cgi): failed to open stream: No such file or directory in /var/www/html/ubbnews.php on line 54
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
quick question, is it possible to have the username as a link to the users profile?
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Regarding first report - I'll look into that one. I'm probably going to have to do some sort of array count to see how many topics.
The 2nd one. Well... The usernumber is already in the A line so it isn't hard to assemble the name as a URL and display. I suppose I could whip that up this evening. Doesn't look like that would be too difficult.
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Zip File Updated with the member name now linking to their profile.
Still looking at the topic counting issue.
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Zip File Updated patching the topic counting bug.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
hummm, sub, can you post these fixes lol... i hate doing customization then having an update lol
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
Ok, I have a new one! How about filtering out the edited by statement...
[ September 29, 2003, 11:40 PM: Message edited by: Gizmo ]
for example...
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Lemme look at the topic files and see how it is in the Z lines. I'm not sure if there will be a sane way to do it...
I'll rustle up the code changes and add those. It's only about 7 new lines that fix both of the above issues.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
sweet, work on the quote issue, it'll make us all feel a lot better :x...
|
|
|
|
|
Joined: Jan 2003
Posts: 3,456 Likes: 2
Master Hacker
|
|
Master Hacker
Joined: Jan 2003
Posts: 3,456 Likes: 2 |
 and lists... they mess up too
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
I'll get it on the bug list to look into/fix.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
quote: Originally posted by Weird Al: and lists... they mess up toothe lists? lol...
|
|
|
|
|
Joined: Jan 2003
Posts: 3,456 Likes: 2
Master Hacker
|
|
Master Hacker
Joined: Jan 2003
Posts: 3,456 Likes: 2 |
http://www.alforadmin.com/ubb/index.php Look at the top news... and the "Read more".. it's added to the [list]
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
hmmm...looks like I need to see if there are open list/quote tags and close them in the tease. This should be interesting.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
Hey Sub, here's a quick beta of what i've done with your script (yeh i know it's still kinda lame/buggy) UGN Security Test Page
|
|
|
|
|
Joined: Jan 2003
Posts: 3,456 Likes: 2
Master Hacker
|
|
Master Hacker
Joined: Jan 2003
Posts: 3,456 Likes: 2 |
quote: Originally posted by Gizzy: Hey Sub, here's a quick beta of what i've done with your script (yeh i know it's still kinda lame/buggy) UGN Security Test Page *cough* mine works with the Colorforums hack *cough* http://www.alforadmin.com/ubb/index.php 
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
I don't need color forums hack though, mines just for my main page's content...
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
Sub, i found another error :choff:... before you say it's one of my mods to it a clean copy my modded copy . My issue is this, it doens't always update and i'd hate to have to rebuild my forum statistics to get it to update all the time... We have like 20 posts from today and it's not showing any of them...
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Did you do fetch the one with sort fix Gizzy? If not, I'll put the sort patch up here. If you did, then I'll need to look and see why it has gone insane.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
sub, the clean.php is the one i just downloaded :x...
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Aye Aye Aye....I'll have to see if I remembered the sort fix in the zip on my server. If I did...welllll..I've got a problem
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
lol, i can't wait to get it working  ... spent a bit of time customizing it lol, it'll pull the site together a bit...
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
Doh! I forgot to commit the sort fix to the released version. I had it on my production version. I'll fix the zip. Patch: Find: $thr_data = array_reverse($thread_data); Replace with: $thr_data2 = array_reverse($thread_data);
array_pop($thr_data2);
sort($thr_data2);
$thr_data = array_reverse($thr_data2);
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
mmm, makes it work perfectly! Now to get the quotes fixed :x... thanks
|
|
|
|
|
Joined: Sep 2001
Posts: 93
Member
|
|
Member
Joined: Sep 2001
Posts: 93 |
i dont get  on my test forum it runs well: http://www.greek-covers.de/ubbtest/ubbnews3.php?forum=1 (ubb 6.6.1 - apache server) on my regular forum it just says quote:
Unable to read .threads file. Either you are trying to access a private forum, or you need to Rebuild your forum stat files. (ubb 6.6.1 - apache server) it's the same software, the same script all the same but no work why is that like this ?!
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
rebuild your forum stat files then try it, I had the same issue and it cleared it up quite quickly.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
For anyone running this who wants to use smilies in their news, you can use the <BASE href="http://www.undergroundnews.com/ubb/"> to point to your ubb directory in your page that you're including from. Be sure however that in that document that you're linking directly to any images/pages/css that you have in the document since it'll look for them in your ubb directory. This is of coarse if you don't want to use a php implode to display your news and just want to use a common include. Sub, as a sugguestion, perhaps have it so that the location of images loaded through your script is passed through the script and pointed back to the ubb directory?
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
The script already can see the NonCGI directory path via the UBB's config.inc.php (Line 7: include("$varspath/vars_config.inc.php");) so it shouldn't take much to get the path to the images. I've been swamped with other development so I haven't had a chance to look at the known issues lately. I have injected some code in my dev version to try to squash the list/code/quote problems but I haven't even touched that in a couple weeks.
Another alternative is to drop the ubbnews.php into your UBB's noncgi directory.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
Sub, if you use a php include it doesn't matter where it's placed, it'll call the paths from that location.
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
:bump: any hope on an update sub?
|
|
|
|
|
Joined: Jan 2000
Posts: 5,833 Likes: 20
UBBDev / UBBWiki Owner
Time Lord
|
|
UBBDev / UBBWiki Owner
Time Lord
Joined: Jan 2000
Posts: 5,833 Likes: 20 |
For those of you wondering how to customize the script's output, check here
|
|
|
|
|
Joined: Nov 2001
Posts: 745
Admin Emeritus
|
|
Admin Emeritus
Joined: Nov 2001
Posts: 745 |
I think the quote/list/code issue is mostly squashed. Let me beat up on my beta version a bit more. I finally had a few days to do some development.
|
|
|
|
|
Joined: Jan 2003
Posts: 3,456 Likes: 2
Master Hacker
|
|
Master Hacker
Joined: Jan 2003
Posts: 3,456 Likes: 2 |
ya know you're really going through too much trouble. All I did was change the layout so that the Read More, etc links were in the next cell. blockquote, lists, etc don't pass through that. So essentially the only reason to update the script is for html compliance
|
|
|
Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.
Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
|
|
|
Posts: 69
Joined: January 2001
|
|
|
Forums63
Topics37,573
Posts293,925
Members13,849
| |
Most Online5,166
Sep 15th, 2019
|
|
Currently Online
Topics Created
Posts Made
Users Online
Birthdays
|
|
|
|
