IIP 5.3.1, index.php<br /><br /><br /><br />Does the first authenticate() call serve any purpose?<br />

I thought about this also... and decided to delete the first one. <img src="/forum/images/graemlins/wink.gif" alt="" /><br />

I am not the expert. But I wouldn't think so.<br /><br />I also ponder if duplicate authenticate calls (like in the sidebar) create trouble.<br /><br />The sidebar would need it if it's on the left... but then the threads on the right also calls it.<br /><br />On the right, it would be unneeded.<br /><br />Some (admins) get an error at the top of the sidebar when it's on the right about output already being sent. <img src="/forum/images/graemlins/crazy.gif" alt="" /><br /><br />But it's not consistant. <img src="/forum/images/graemlins/tongue.gif" alt="" />

I haven't looked at the sidebar thing, but in this case, it should be orphan.<br />There's no additional code or includes between the two calls and the user object gets overwritten.

The only thing is that authenticate() does some tricky stuff, and I was wondering if there's some subtle side effect that's being depended on.

Well, remember, SideBar needs some infromation of its own. I tried to change it to a simple SELECT, but it didnt take so was going to try again later.

That's true....<br /><br />But maybe the info that the sidebar needs should be added into the Authenticate function of ubbt.inc.php.<br /><br />Although if there's no problem with calling it twice, then it can't hurt. <br /><br />I've asked Rick's opinion on calling it twice.

I've been looking at something similar with the data base queries in the addons. I't sems to me that it would be easier (and faster) to combine some of the queries and then set up a loop to create arrays out of them. Then just use a loop in a template to echo out the html / array data (kinda like the way the postlist and showflat / showthreaded pages work).<br /><br />The addons also use some of the same variables, so I'm consolidating all of them into an "addon.inc.php" file. No sense in wasting time creating the same variables over and over...