UBB.Developers Forums UBB.threads 6 V6 Modifications Templates Bug in templates UBB.threads™ 6.3b1

XXX find in tht ubbthreads.tmpl:

<!-- END OF FORUM LOOP -->
</table>
</td>
</tr>
</table>

XXX replace it:

<!-- END OF FORUM LOOP -->

$tbclose

XXX end
================================

Next

XXX find in tht myhome.tmpl:

<!-- END ONLINE LOOP -->

</table>
</td>
</tr>
$tbclose

XXX replace it:

<!-- END ONLINE LOOP -->

$tbclose
</table>
</td>
</tr>

XXX end
================================

Nettomo

Thanks! I'll make sure I fix those bugs when I release my modified templates

Replied on Infopop to this but want to make sure everyone sees this. I don't think that second fix is right. That change will make the HTML look like this:

</table>
</td>
</tr>
</table>
</table>

Which definitely isn't valid

Yeah the my home looks fine as it is

</table>
</td>
</tr>
$tbclose

Is correct.

Hi omegatron ,
ist in ordnung,
nur wenn du mit der "tbopen.tmpl" & "tbclose.tmpl" arbeitest ,
wie zb. mit "Chrome table wrapper " usw.
dann gibt es probleme

================

Rear one omegatron, is correct, only if you work with "tbopen.tmpl" & "tbclose.tmpl", like e.g. with "chrome table more wrapper" etc. then gives it problems

Sorry Babel Fish tranclator

Nettomo

Actually, in myhome.tmpl in 6.2.3 it has:



So which is right?

Hi AKD96,
we talks about "UBB.threads? 6.3b1"

Nettomo

Yeah, I know. In 6.2.3 the order is different as compared to 6.3br1.

6.2.3

6.3br1

It's not just the placement of $tbclose. Which one is correct?

Either one of those will validate if the table tr and td tags are closed.

The one Nettomo posted will not validate any which way.

The issue with MyHome that was fixed for 6.3.... is that useing the $tbopen and $tbclose in the private message / friends table and you are using a fixed table width (as opposed to a percentage) in the theme file.....
well you can imagine... it doesn't look right.

So I think this one:

</table>
</td>
</tr>
$tbclose

is correct. But I haven't tested.

If you're using a % table width, all should be fine.

As I stated above Rick got it right in 6.3

</table>
</td>
</tr>
$tbclose

This is validated by W3C org. I ran it on my test site with 6.3

This is looking like the failure I found regarding the sidebar.

In [6.2.x] is the same error. You can only see it if you use the table wrapper or the sidebar hack otherwise its not displayed and looking fine