[6.2] Quick Reply 3.0

You are not logged in. [Log In] ubbDev » Forums » Vintage Modifications » UBB.Threads v6.x Modifications
» Archived Modifications » [6.2] Quick Reply 3.0

Page 1 of 9

Topic Options

#230043 - 12/26/02 10:03 AM [6.2] Quick Reply 3.0
JoshPet I type Like navaho Registered: 11/29/01 Posts: 11330 Loc: Charlotte, NC	MOD NAME: QUICK REPLY MOD 3.0 <br /> <br />DESCRIPTION: Adds a quick reply box to the bottom of a thread. Version 3.0 adds a Pulldown Menu for Post Icons, a Preview Post Button, a Spellcheck button and a popup Graemlin Panel (thanks JustDave) <br /> <br />BY: JoshPet, Allen Ayres, Gardener and JustDave for bug fixes <br /> <br />DATE: 12.26.2002 <br /> <br />CREDITS: Allen Ayres for version 1, Gardener for Javascript, JustDave for bug fixes and Graemlin Popup, JoshPet for bug fixes and enhancements. German translation by jluerken. <br /> <br />VERSION: 3.0 for UBB.Threads 6.2 <br /> <br />REQUIREMENTS: A full version of UBB.Threads 6.2 <br />COMPATIBILITY: UBB.Threads 6.2 <br /> <br />DEMO: login at www.measurection.com with username: testing and password: testing <br /> <br />FILES MODIFIED: showflat.tmpl, showflat.php, languages/english/showflat.php, showthreaded.php, showthreaded.tmpl, languages/generic.php <br /> <br />NEW FILES: graemlinpanel.php (thanks JustDave!) NOTE: If you are using JustDave's Popup Graemlin modification already, you don't need to add this file. The script is the same. <img src="/forum/images/graemlins/wink.gif" alt="" /> <br /> <br />Version history: <br /> Version 1.0: released (08/10/2002) Version 1.1: ubbcode parsed and post icons fixed (08/11/2002) Version 1.2: Quick Reply only avail. to Logged in User Correctly adds the "Re:" (only once) to reply. (08/12/2002 Version 1.3: Languages settings added (08/12/2002) Version 1.4: Fix added to remove box if thread is closed (08/13/2002) Version 1.5: User can select which post to reply to. (08/14/2002) Version 1.6: Fixed "Re:" issue with Javascript and added code so quick reply link does not appear if the user is not logged in or the thread is closed (08/17/2002) Version 1.7: Javascript adds the quote instead of replacing. (08/18/2002) "Re:" checking added to javascript. Added a quick reply box to threaded view as well. Version 1.8: Quick Reply now works with Mozilla, Opera won't break. Fixed a bug when replying to anonymous posts. Now adds the username correctly. * Version 2.0: Updated for UBB.Threads 6.2 (12/26/2002) by JoshPet. This simply does a quick reply and not a quick quote as the Auto Quote is now a standard function of Threads Version 2.1: With JustDave's help we've finally licked the problem voting in polls when Quick Reply was installed. Version 2.2: Fixes a bug which allowed a reply to a moved post pointer and created some wacky results. 1/12/03 Version 3.0: Adds a pulldown menu for Post Icons, a preview Post Button, a Spell Check Button, and a popup Graemlin Panel (thanks JustDave <img src="/forum/images/graemlins/smile.gif" alt="" /> ) 2/1/03 <br /> <br /> <br />For discussion and bug reports, please come here: <br />http://www.threadsdev.com/ <br /> <br />PLEASE MAKE BACKUP COPIES OF EVERY FILE YOU PLAN TO MODIFY!! <br /> <br />Note: If you are running JustDave's very popular "Reply to Who" mod, you won't be able to find the code it tells you to find in showflat.php <br /> <br />Instead, look for the second occurance of this: <br /> <br />$postrow[$i]['Subject'] = $Subject; <br /> <br /> <br />Change to this: <br /> <br />$postrow[$i]['Subject'] = "<span id=\"subject$i\">$Subject</span>"; <br /> <br /> <br /><img src="/forum/images/graemlins/smile.gif" alt="" /> Attachments 62542-QuickReply3.0.zip (221 downloads) Edited by JoshPet (02/22/03 11:02 PM) _________________________ Joshua Pettit www.JoshuaPettit.com My abilities are for hire.
Top

#230044 - 12/26/02 02:19 PM Re: [6.2] Quick Reply 2.0 [Re: Daine]
Pappy Member Registered: 11/17/00 Posts: 235 Loc: Germany (US Citizen)	Hi Josh,<br /><br />I was wondering if the bug where it caused Polls not to work properly in showflat was fixed or was ever tracked down? I useed to use this on my site and it was great but I am leary of reinstalling it since we use a lot of Polls. Thanks<br /><br />
Top

#230045 - 12/26/02 02:26 PM Re: [6.2] Quick Reply 2.0 [Re: MercAqua]
JoshPet I type Like navaho Registered: 11/29/01 Posts: 11330 Loc: Charlotte, NC	I had the poll issue on my site in 6.2 in testing and prior to installing the quick reply mod. <br /><br />Myself and Navaho experienced the poll bug at our development board. Not sure what exactly makes polls work for some and not for others. <img src="/forum/images/graemlins/crazy.gif" alt="" /><br /><br />So since polls weren't working right for all my users anyway, I went ahead and installed the quick reply mod. <br /><br />I'm going to do some more testing with the poll thing. But I don't think it's quick reply related. I still can't vote in a poll here at threadsdev... and we don't have quick reply installed. <img src="/forum/images/graemlins/tongue.gif" alt="" /><br /><br />One poll for me it works... one poll for me it doesn't. I always use flat. I have threaded users who get the "not found" error too. So I haven't really found the common factor yet. _________________________ Joshua Pettit www.JoshuaPettit.com My abilities are for hire.
Top

#230046 - 12/26/02 02:28 PM Re: [6.2] Quick Reply 2.0 [Re: Daine]
Pappy Member Registered: 11/17/00 Posts: 235 Loc: Germany (US Citizen)	EEK<br />Thanks for the "quick reply"<br />(Pun Intended hehe)<br /><img src="/forum/images/graemlins/smile.gif" alt="" />
Top

#230047 - 12/26/02 08:32 PM Re: [6.2] Quick Reply 2.0 [Re: MercAqua]
JoshPet I type Like navaho Registered: 11/29/01 Posts: 11330 Loc: Charlotte, NC	I may have spoken too soon. <img src="/forum/images/graemlins/crazy.gif" alt="" /><br /><br />Now if I come back here and contradict myself, that'll probably cause troubles. Anyway, I had a couple of users early on complain about the poll. But it must have been something else. <img src="/forum/images/graemlins/tongue.gif" alt="" /> <br /><br />I've had a good number of users testing a couple of polls, and no trouble. We've also tested at our development board. <br /><br /><shrug><br /><br />Time will tell if it surfaces again. <img src="/forum/images/graemlins/tongue.gif" alt="" /><br /><br />Let me know if you use this mod and see any trouble. <img src="/forum/images/graemlins/smile.gif" alt="" /> _________________________ Joshua Pettit www.JoshuaPettit.com My abilities are for hire.
Top

#230048 - 12/26/02 10:35 PM Re: [6.2] Quick Reply 2.0 [Re: Daine]
Pappy Member Registered: 11/17/00 Posts: 235 Loc: Germany (US Citizen)	I will, I havent upgraded yet to 6.2 and plan on testing this weekend on an offline server (so I can clean up any other Mods that may go haywire) I will definately keep you updated on the results <br /><br />Thanks Josh
Top

#230049 - 12/29/02 02:33 AM Re: [6.2] Quick Reply 2.0 [Re: MercAqua]
JoshPet I type Like navaho Registered: 11/29/01 Posts: 11330 Loc: Charlotte, NC	Pappy,<br /><br />Just to update. The issue of polls seems to be cleared up in a "clean" install of threads.<br /><br />I had one or two errors reported when I was on a clean copy. There may still be something lingering, but it was very isolated. Might have been a browser thing.<br /><br />I added in Quick Reply, and the problem seemed better. Some errors did pop up though. It seems that if the poll is the first in the thread, it doesn't work right for everyone if quick reply is installed. But if the poll is in a reply, it seems to work better. Go figure.<br /><br />I'm determined to solve this so it's totally bug free if it kills me. LOL <img src="/forum/images/graemlins/tongue.gif" alt="" /> I'll go through this again, and make sure there are no conflicting variables. When I try to validate the page with quick reply, it says there's an extra </form> tag. That could be the culprit...since a poll is a form, that could goof things up.<br /><br />If I can't nail it down, plan B would be to redesign it so it doesn't appear at all if there's a poll in the thread. <img src="/forum/images/graemlins/grin.gif" alt="" /> Might be the best way around it. <img src="/forum/images/graemlins/smile.gif" alt="" /><br /><br />So if you use alot of polls, hold off on the quick reply. <img src="/forum/images/graemlins/smile.gif" alt="" /> _________________________ Joshua Pettit www.JoshuaPettit.com My abilities are for hire.
Top

#230050 - 12/29/02 02:40 AM Re: [6.2] Quick Reply 2.0 [Re: Daine]
JustDave That 70's Guy Registered: 06/24/01 Posts: 4097	Just a thought... What seemed to be happening was that dopoll.php wasn't getting all of the values of the variables that are passed to it when a person votes. Check for additional <form> tags of course and in the case of javascript being used make sure that the forms have specific names so that only one can be referenced.<br /><br /> _________________________ ~Dave ChattersOnline.com
Top

#230051 - 12/30/02 10:27 PM Re: [6.2] Quick Reply 2.0 [Re: Daine]
JustDave That 70's Guy Registered: 06/24/01 Posts: 4097	Josh I was about to add this here when I noticed what may be the cause of the poll problems. Do you have a site I can see this up and running at? I can't say completely sure by looking at the code. I need to see the html it's generating. <img src="/forum/images/graemlins/smile.gif" alt="" /> _________________________ ~Dave ChattersOnline.com
Top

#230052 - 12/30/02 11:19 PM Re: [6.2] Quick Reply 2.0 [Re: sjsaunders]
JoshPet I type Like navaho Registered: 11/29/01 Posts: 11330 Loc: Charlotte, NC	I had taken it off my site. But I just put the files back so it's there.<br /><br />You will be the Hero for fixing this. I don't think it validates. LOL<br /><br />I'll PM you with a login to my site ... as you have to login to test. _________________________ Joshua Pettit www.JoshuaPettit.com My abilities are for hire.
Top

#230053 - 12/30/02 11:33 PM Re: [6.2] Quick Reply 2.0 [Re: Daine]
JustDave That 70's Guy Registered: 06/24/01 Posts: 4097	Ok I believe the problem is that there are forms within forms. This must be messing with the values that get sent to dopoll.php<br /><br />I'll go over the code tomorrow some when I get a change and see how to fix it. <img src="/forum/images/graemlins/smile.gif" alt="" /><br /><br />I kinda have an idea how since I noticed the possible error while reading your instructions. What your doing is placing a new <form name="posts".... before the body ($printbody)? of the post being displayed. Then closing the form after the body is displayed. Any post inside that contains a poll may be impaired. <img src="/forum/images/graemlins/crazy.gif" alt="" /> _________________________ ~Dave ChattersOnline.com
Top

#230054 - 12/30/02 11:48 PM Re: [6.2] Quick Reply 2.0 [Re: sjsaunders]
JoshPet I type Like navaho Registered: 11/29/01 Posts: 11330 Loc: Charlotte, NC	That whole FORM thing kind of confused me. I really didn't "create" it as you know. Allen started and Gardener did the JavaScript stuff. But it seemed to be an extra </form> in the HTML when I validated the page (or tried to) but I couldn't figure out what it was doing.<br /><br />Dave will win the UBB.Threads Noble Prize for sure if he fixes Quick Reply. <img src="/forum/images/graemlins/grin.gif" alt="" /><br /><br /> _________________________ Joshua Pettit www.JoshuaPettit.com My abilities are for hire.
Top

#230055 - 12/30/02 11:57 PM Re: [6.2] Quick Reply 2.0 [Re: Daine]
JustDave That 70's Guy Registered: 06/24/01 Posts: 4097	I may try installing it yet tonight and just work the bugs out from here... lol <img src="/forum/images/graemlins/wink.gif" alt="" /> _________________________ ~Dave ChattersOnline.com
Top

#230056 - 12/31/02 02:47 PM

Re: [6.2] Quick Reply 2.0 [Re: Daine]

JustDave Offline

That 70's Guy

Registered: 06/24/01
Posts: 4097

Ok this seems to be working... <img src="/forum/images/graemlins/smile.gif" alt="" /> What I changed, actually excluded, was this step:

Code:

<br />##<br />## Find this: (not sure)<br />##<br /><br />&lt;/td&gt;<br />&lt;/tr&gt;<br />$tbclose<br /><br />&lt;br /&gt;<br /><br />$tbopen<br />&lt;tr&gt;<br />&lt;td colspan="2" class="tdheader"&gt;<br />$pageprint<br />&lt;/td&gt;<br />&lt;/tr&gt;<br />UBBTPRINT;<br /><br /><br />##<br />## Change to this:<br />##<br /><br />&lt;/td&gt;<br />&lt;/tr&gt;<br />$tbclose<br /><br />&lt;br /&gt;<br /><br />&lt;form name="posts" id="posts"&gt;<br />$tbopen<br />&lt;tr&gt;<br />&lt;td colspan="2" class="tdheader"&gt;<br />$pageprint<br />&lt;/td&gt;<br />&lt;/tr&gt;<br />UBBTPRINT;<br />

and then I removed the </form> closing tag from here:

Code:

<br />$pageprint<br />&lt;/td&gt;<br />&lt;/tr&gt;<br />$tbclose<br /><br />[:"red"]&lt;/form&gt;[/]<br />UBBTPRINT;<br /><br />// -----------------------------------------------------<br />// Make sure we only put one Re: in front of the subject<br />   if (!ereg("Re:",$Subject) ) {<br />      $Subject = "Re: ".$Subject;<br />   }<br /><br /><br />if (($user['U_Username']) &amp;&amp; ($Open != "C")) {<br />echo &lt;&lt;&lt;UBBTPRINT<br />&lt;table width="{$theme['tablewidth']}" align="center" cellpadding="1" cellspacing="1" class="tablesurround"&gt;<br />&lt;tr&gt;<br />&lt;td&gt;<br />&lt;table cellpadding="4" cellspacing="1" width="100%" class="tableborders"&gt;<br />&lt;tr&gt;<br />&lt;td valign="top" class="tdheader" colspan="2"&gt;<br />{$ubbt_lang['QUICK_REPLY']}&lt;/td&gt;&lt;/tr&gt;<br />&lt;tr&gt;<br />&lt;td valign="top" class="darktable" width="17%"&gt;<br />&amp;nbsp; &lt;/td&gt;<br />&lt;td valign="top" class="lighttable"&gt;<br />&lt;form method="post" enctype='multipart/form-data' action="{$config['phpurl']}/addpost.php" name="replier"&gt;<br />&lt;input type="hidden" name="postername" value="{$user['U_Username']}" /&gt;<br />&lt;input type="hidden" name="Board" value="$Board" /&gt;<br />&lt;input type="hidden" name="Cat" value="$Cat" /&gt;<br />&lt;input type="hidden" name="Reged" value="y" /&gt;<br />&lt;input type="hidden" name="page" value="$page" /&gt;<br />&lt;input type="hidden" name="Main" value="$current" /&gt;<br />&lt;input type="hidden" name="Parent" value="$Number" /&gt;<br />&lt;input type="hidden" name="view" value="$view" /&gt;<br />&lt;input type="hidden" name="what" value="showflat" /&gt;<br />&lt;input type="hidden" name="sb" value="$sb" /&gt;<br />&lt;input type="hidden" name="o" value="$o" /&gt;<br />&lt;input type="hidden" name="oldnumber" value="$oldnumber" /&gt;<br />&lt;input type="hidden" name="fpart" value="$fpart" /&gt;<br />&lt;input type="hidden" name="vc" value="$vc" /&gt;<br />&lt;input type="hidden" name="replyto" value="$ResUsername" /&gt;<br />&lt;input type="hidden" name="Icon" value="book.gif" $book /&gt;<br />&lt;input type="hidden" name="convert" value="markup" /&gt;<br />&lt;input type="text" name="Subject" maxlength="{$config['subjectlength']}" class="formboxes" size="60" value="$Subject" /&gt;&lt;br /&gt;<br />&lt;textarea cols="60" rows="10" class="formboxes" name="Body" onkeyup="storeCaret(this);" onclick="storeCaret(this);"&gt;&lt;/textarea&gt;<br />&lt;br /&gt;<br />&lt;br /&gt;<br />&lt;input type="submit" name="textcont" value="{$ubbt_lang['TEXT_CONT']}" class="buttons" /&gt;<br />&lt;/form&gt;<br />&lt;/td&gt;&lt;/tr&gt;<br />&lt;/table&gt;&lt;/td&gt;&lt;/tr&gt;&lt;/table&gt;<br />UBBTPRINT;<br />} //UBBTREMARK<br /><br />echo &lt;&lt;&lt;UBBTPRINT<br /><br />&lt;br /&gt;<br />$tbopen<br /><br />

There didn't seem to be a purpose for this form. Hope this works for everyone else. <img src="/forum/images/graemlins/smile.gif" alt="" />

_________________________
~Dave
ChattersOnline.com

Top

#230057 - 12/31/02 03:38 PM Re: [6.2] Quick Reply 2.0 [Re: sjsaunders]
Ian_W Veteran Registered: 02/22/02 Posts: 2575 Loc: England	Dave,<br /><br />Installed with your modifications - and it is working fine in flatmode - and allows polls to be placed - and voted upon. <br /><br />However in Threaded view - I get an error on line 610 object expected character 1.<br /><br />This is <br /> $sth = $dbh -> do_query($query);<br /><br />However the error, allows the quick reply box to be filled and submitted without further error. (polls also work in threaded)<br /><br />Ian _________________________ Fans Focus - Focusing on Fans of Sport (Okay - mainly football (the British variety at the moment - but expanding all the time....)
Top

#230058 - 12/31/02 03:41 PM Re: [6.2] Quick Reply 2.0 [Re: Gorlum]
Ian_W Veteran Registered: 02/22/02 Posts: 2575 Loc: England	FYI - I also get the same error here on threaded, but this time on line 399 <img src="/forum/images/graemlins/confused.gif" alt="" /><br /><br />Ian _________________________ Fans Focus - Focusing on Fans of Sport (Okay - mainly football (the British variety at the moment - but expanding all the time....)
Top

#230059 - 12/31/02 03:54 PM Re: [6.2] Quick Reply 2.0 [Re: Gorlum]
JustDave That 70's Guy Registered: 06/24/01 Posts: 4097	I hardly ever user threaded... lol<br /><br /><br />I knew the polls worked, or at least I thought they were working, in threaded so I never checked to see otherwise.<br /><br />Is it a javascript error or an actuall database/php error? _________________________ ~Dave ChattersOnline.com
Top

#230060 - 12/31/02 04:07 PM Re: [6.2] Quick Reply 2.0 [Re: Gorlum]
JustDave That 70's Guy Registered: 06/24/01 Posts: 4097	Your probably seeing a javascript error for what ever browser your using, IE perhaps?<br /><br />I don't believe that the code in this line: (in red)<br /><br /><textarea cols="60" rows="10" class="formboxes" name="Body" [:"red"]onkeyup="storeCaret(this);" onclick="storeCaret(this);[/]"><br /><br />servers any purpose.<br /><br /><br />That is unless your using the instant ubbcode panel.<br /><br /> _________________________ ~Dave ChattersOnline.com
Top

#230061 - 12/31/02 04:09 PM Re: [6.2] Quick Reply 2.0 [Re: Gorlum]
JustDave That 70's Guy Registered: 06/24/01 Posts: 4097	Does that code server any purpose in either flat or threaded? _________________________ ~Dave ChattersOnline.com
Top

#230062 - 12/31/02 05:28 PM Re: [6.2] Quick Reply 2.0 [Re: sjsaunders]
Storm_dup1 Member Registered: 08/03/02 Posts: 263 Loc: Somewhere above Texas	_________________________ Some people read their stars..... I choose to write my own
Top

Page 1 of 9

Previous Topic

Index

Next Topic

Hop to: